-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-17953: [Archery] Add archery docker info command #14345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
assignUser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool idea! Looks good overall, As a minor thing I am not sure if I like the addition of - for structuring the output or if it just adds noise and only indentation would be cleaner?
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
|
@pitrou @assignUser this should be ready to review again. Thanks for the feedback! |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
assignUser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally, looks good 👍
|
I've noticed something: Printing |
…r info command is None as it would be inherited from shell environment values
|
+1 |
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @raulcd !
Some usage examples:
or
or
edited only the commands to reflect the change of the command --show