Skip to content

Conversation

@rok
Copy link
Member

@rok rok commented Sep 21, 2022

This is to add DELTA_BINARY_PACKED encoder.

@rok
Copy link
Member Author

rok commented Sep 21, 2022

This is not really review ready yet.

@github-actions
Copy link

@rok rok force-pushed the ARROW-17798 branch 5 times, most recently from bd0f693 to 641dfd6 Compare September 30, 2022 04:16
@rok rok force-pushed the ARROW-17798 branch 3 times, most recently from b67d895 to 4217379 Compare October 2, 2022 21:44
@rok rok force-pushed the ARROW-17798 branch 3 times, most recently from 36f33cb to 786e689 Compare October 3, 2022 03:19
@rok rok marked this pull request as ready for review October 3, 2022 11:50
@pitrou
Copy link
Member

pitrou commented Oct 3, 2022

@shanhuuang Do you want to take a look here?

@pitrou pitrou merged commit 1b3d4af into apache:master Dec 14, 2022
@pitrou
Copy link
Member

pitrou commented Dec 14, 2022

I'm glad this is in! Congrats!

@rok
Copy link
Member Author

rok commented Dec 14, 2022

Thanks for all the reviews @pitrou & others :)

@mapleFU
Copy link
Member

mapleFU commented Dec 15, 2022

@rok @pitrou @wgtmac
Hi, all, I found a bug here. When calling flushValues, it didn't:

  • clearing the total_value_count_
  • Re-advancing buffer for kMaxPageHeaderWriterSize

I have a bug fixing, and I submit a fixing here: #14959

@ursabot
Copy link

ursabot commented Dec 15, 2022

Benchmark runs are scheduled for baseline = 36824d1 and contender = 1b3d4af. 1b3d4af is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.43% ⬆️0.0%] test-mac-arm
[Finished ⬇️1.9% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.1% ⬆️0.34%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 1b3d4afc ec2-t3-xlarge-us-east-2
[Finished] 1b3d4afc test-mac-arm
[Finished] 1b3d4afc ursa-i9-9960x
[Finished] 1b3d4afc ursa-thinkcentre-m75q
[Finished] 36824d1b ec2-t3-xlarge-us-east-2
[Finished] 36824d1b test-mac-arm
[Finished] 36824d1b ursa-i9-9960x
[Finished] 36824d1b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants