ARROW-17751: [Go][Benchmarking] Add Go Benchmark Script #14148
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| #!/usr/bin/env bash | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # this will output the benchmarks to STDOUT but if `-json` is passed | ||
| # as the second argument, it will create a file "bench_stats.json" | ||
| # in the directory this is called from containing a json representation | ||
|
|
||
| set -ex | ||
|
|
||
| # simplistic semver comparison | ||
| verlte() { | ||
| [ "$1" = "`echo -e "$1\n$2" | sort -V | head -n1`" ] | ||
| } | ||
| verlt() { | ||
| [ "$1" = "$2" ] && return 1 || verlte $1 $2 | ||
| } | ||
|
|
||
| ver=`go env GOVERSION` | ||
|
|
||
| source_dir=${1}/go | ||
|
|
||
| export PARQUET_TEST_DATA=${1}/cpp/submodules/parquet-testing/data | ||
| pushd ${source_dir} | ||
|
|
||
| go test -bench=. -benchmem -run=^$ ./... | tee bench_stat.dat | ||
|
|
||
| if verlte "1.18" "${ver#go}"; then | ||
| go test -bench=. -benchmem -run=^$ ./arrow/compute | tee bench_stat_compute.dat | ||
| fi | ||
|
|
||
| popd | ||
|
|
||
| if [[ "$2" = "-json" ]]; then | ||
| go install go.bobheadxi.dev/gobenchdata@latest | ||
| export PATH=`go env GOPATH`/bin:$PATH | ||
| cat ${source_dir}/bench_*.dat | gobenchdata --json bench_stats.json | ||
| fi | ||
|
|
||
| rm ${source_dir}/bench_*.dat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| import json | ||
| import os | ||
| import uuid | ||
| import logging | ||
| from pathlib import Path | ||
| from typing import List | ||
|
|
||
| from benchadapt import BenchmarkResult | ||
| from benchadapt.adapters import BenchmarkAdapter | ||
| from benchadapt.log import log | ||
|
|
||
| log.setLevel(logging.DEBUG) | ||
|
|
||
| ARROW_ROOT = Path(__file__).parent.parent.parent.resolve() | ||
| SCRIPTS_PATH = ARROW_ROOT / "ci" / "scripts" | ||
|
|
||
| class GoAdapter(BenchmarkAdapter): | ||
| result_file = "bench_stats.json" | ||
| command = ["bash", SCRIPTS_PATH / "go_bench.sh", ARROW_ROOT, "-json"] | ||
|
|
||
| def __init__(self, *args, **kwargs) -> None: | ||
| super().__init__(command=self.command, *args, **kwargs) | ||
|
|
||
| def _transform_results(self) -> List[BenchmarkResult]: | ||
| with open(self.result_file, "r") as f: | ||
| raw_results = json.load(f) | ||
|
|
||
| run_id = uuid.uuid4().hex | ||
| parsed_results = [] | ||
| for suite in raw_results[0]["Suites"]: | ||
| batch_id = uuid.uuid4().hex | ||
| pkg = suite["Pkg"] | ||
|
|
||
| for benchmark in suite["Benchmarks"]: | ||
| data = benchmark["Mem"]["MBPerSec"] * 1e6 | ||
| time = 1 / benchmark["NsPerOp"] * 1e9 | ||
|
|
||
| name = benchmark["Name"].removeprefix('Benchmark') | ||
| ncpu = name[name.rfind('-')+1:] | ||
| pieces = name[:-(len(ncpu)+1)].split('/') | ||
|
|
||
| parsed = BenchmarkResult( | ||
| run_id=run_id, | ||
| batch_id=batch_id, | ||
| stats={ | ||
| "data": [data], | ||
| "unit": "b/s", | ||
| "times": [time], | ||
| "time_unit": "i/s", | ||
| "iterations": benchmark["Runs"], | ||
| }, | ||
| context={ | ||
| "benchmark_language": "Go", | ||
| "goos": suite["Goos"], | ||
| "goarch": suite["Goarch"], | ||
| }, | ||
| tags={ | ||
| "pkg": pkg, | ||
| "num_cpu": ncpu, | ||
| "name": pieces[0], | ||
| "params": '/'.join(pieces[1:]), | ||
| }, | ||
| run_reason=f'commit', | ||
|
Contributor
There was a problem hiding this comment. Is this only going to run on master? If so, this is fine; if not, it needs to be flipped from gh actions
Member
Author
There was a problem hiding this comment. Updated to have the reason derived by checking the branch |
||
| ) | ||
| parsed.run_name = f"{parsed.run_reason}: {parsed.github['commit']}" | ||
| parsed_results.append(parsed) | ||
|
|
||
| return parsed_results | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| go_adapter = GoAdapter(result_fields_override={"info":{}}) | ||
| go_adapter() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -257,19 +257,19 @@ func testCSVReader(t *testing.T, filepath string, withHeader bool) { | |
|
|
||
| schema := arrow.NewSchema( | ||
| []arrow.Field{ | ||
| {Name: "bool", Type: arrow.FixedWidthTypes.Boolean}, | ||
| {Name: "i8", Type: arrow.PrimitiveTypes.Int8}, | ||
| {Name: "i16", Type: arrow.PrimitiveTypes.Int16}, | ||
| {Name: "i32", Type: arrow.PrimitiveTypes.Int32}, | ||
| {Name: "i64", Type: arrow.PrimitiveTypes.Int64}, | ||
| {Name: "u8", Type: arrow.PrimitiveTypes.Uint8}, | ||
| {Name: "u16", Type: arrow.PrimitiveTypes.Uint16}, | ||
| {Name: "u32", Type: arrow.PrimitiveTypes.Uint32}, | ||
| {Name: "u64", Type: arrow.PrimitiveTypes.Uint64}, | ||
| {Name: "f32", Type: arrow.PrimitiveTypes.Float32}, | ||
| {Name: "f64", Type: arrow.PrimitiveTypes.Float64}, | ||
| {Name: "str", Type: arrow.BinaryTypes.String}, | ||
| {Name: "ts", Type: arrow.FixedWidthTypes.Timestamp_ms}, | ||
| }, | ||
| nil, | ||
| ) | ||
|
|
@@ -379,9 +379,9 @@ func TestCSVReaderWithChunk(t *testing.T) { | |
|
|
||
| schema := arrow.NewSchema( | ||
| []arrow.Field{ | ||
| {Name: "i64", Type: arrow.PrimitiveTypes.Int64}, | ||
| {Name: "f64", Type: arrow.PrimitiveTypes.Float64}, | ||
| {Name: "str", Type: arrow.BinaryTypes.String}, | ||
| }, | ||
| nil, | ||
| ) | ||
|
|
@@ -632,7 +632,7 @@ func BenchmarkRead(b *testing.B) { | |
| return buf.Bytes() | ||
| } | ||
|
|
||
| for _, rows := range []int{10, 1e2, 1e3, 1e4} { | ||
| for _, cols := range []int{1, 10, 100, 1000} { | ||
| raw := gen(rows, cols) | ||
| for _, chunks := range []int{-1, 0, 10, 100, 1000} { | ||
|
|
@@ -651,9 +651,9 @@ func benchRead(b *testing.B, raw []byte, rows, cols, chunks int) { | |
| var fields []arrow.Field | ||
| for i := 0; i < cols; i++ { | ||
| fields = append(fields, []arrow.Field{ | ||
| {Name: fmt.Sprintf("i64-%d", i), Type: arrow.PrimitiveTypes.Int64}, | ||
| {Name: fmt.Sprintf("f64-%d", i), Type: arrow.PrimitiveTypes.Float64}, | ||
| {Name: fmt.Sprintf("str-%d", i), Type: arrow.BinaryTypes.String}, | ||
| }...) | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -177,7 +177,7 @@ func benchReadTable(b *testing.B, name string, tbl arrow.Table, nbytes int64) { | |
| b.SetBytes(nbytes) | ||
|
|
||
| for i := 0; i < b.N; i++ { | ||
| pf, err := file.NewParquetReader(bytes.NewReader(buf.Bytes())) | ||
| if err != nil { | ||
| b.Error(err) | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try saving with "strip trailing whitespace"? Just trying to prevent future whitespace diffs