Skip to content

Conversation

@seibs
Copy link
Contributor

@seibs seibs commented Dec 9, 2017

These changes were necessary to compile on Windows with "-DARROW_BUILD_BENCHMARKS=ON". I added Shwlapi based on google/benchmark#202.

@wesm
Copy link
Member

wesm commented Dec 10, 2017

Sweet, thank you. I will take this for a spin when I get a chance and merge if no issues

@seibs
Copy link
Contributor Author

seibs commented Jan 4, 2018

@xhochy - responding to your comments from #1422 here. I reverted the white space change as requested, but the int64_t to int change was required to build on Windows, so I left it as is. When set to int64_t, the build failed complaining about a cast from int64_t to int.

@wesm
Copy link
Member

wesm commented Jan 4, 2018

I added LL to make that an int64 literal. Merging once the build runs

@seibs
Copy link
Contributor Author

seibs commented Jan 5, 2018

Awesome, thanks @wesm - once this is merged I'll rebase my other open pull request.

Use int64 literal

Change-Id: I96ab9edf10aebf2ea26170c90450e7341687e6d3

Revert int64->int because gbenchmark does not allow 64-bit integers in Args
@wesm
Copy link
Member

wesm commented Jan 5, 2018

Turns out the the Args option in google benchmark doesn't accept int64_t. Sorry about the confusion, I've reverted

@wesm wesm closed this in cb9c52e Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants