Skip to content

ARROW-17632: [Python][C++] Add details of where libarrow is being found during build #14059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 5 commits into from
Sep 12, 2022
Merged

ARROW-17632: [Python][C++] Add details of where libarrow is being found during build #14059

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
acc8dc0
ARROW-17632: Add Arrow location info
dhruv9vats Sep 7, 2022
694bc8b
ARROW-17632: Add newline at the end of file
dhruv9vats Sep 7, 2022
06b914b
ARROW-17632: Add function arrow_show_details
dhruv9vats Sep 7, 2022
adf8d28
ARROW-17632: Convert arrow_show_details to macro
dhruv9vats Sep 11, 2022
0db0b42
ARROW-17632: Revert unintended change
dhruv9vats Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cpp/src/arrow/ArrowConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,3 +172,12 @@ endmacro()
arrow_keep_backward_compatibility(Arrow arrow)

check_required_components(Arrow)

if(NOT Arrow_FIND_QUIETLY)
message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})")
Comment thread
dhruv9vats marked this conversation as resolved.
Outdated
message(STATUS "Arrow SO and ABI version: ${ARROW_SO_VERSION}")
message(STATUS "Arrow full SO version: ${ARROW_FULL_SO_VERSION}")
Comment thread
dhruv9vats marked this conversation as resolved.
Outdated
message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
endif()

@kou kou Sep 7, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?