Skip to content

ARROW-17632: [Python][C++] Add details of where libarrow is being found during build #14059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 5 commits into from
Sep 12, 2022
Merged

ARROW-17632: [Python][C++] Add details of where libarrow is being found during build #14059

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
acc8dc0
ARROW-17632: Add Arrow location info
dhruv9vats Sep 7, 2022
694bc8b
ARROW-17632: Add newline at the end of file
dhruv9vats Sep 7, 2022
06b914b
ARROW-17632: Add function arrow_show_details
dhruv9vats Sep 7, 2022
adf8d28
ARROW-17632: Convert arrow_show_details to macro
dhruv9vats Sep 11, 2022
0db0b42
ARROW-17632: Revert unintended change
dhruv9vats Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cpp/src/arrow/ArrowConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,3 +172,16 @@ endmacro()
arrow_keep_backward_compatibility(Arrow arrow)

check_required_components(Arrow)

function(arrow_show_details PACKAGE_NAME)
Comment thread
dhruv9vats marked this conversation as resolved.
Outdated
if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
string(TOUPPER ${PACKAGE_NAME} package_name_upper)
message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
Comment thread
dhruv9vats marked this conversation as resolved.
Outdated
message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}")

@kou kou Sep 9, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with ArrowDataset?

It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))

@dhruv9vats dhruv9vats Sep 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:

macro(arrow_show_details package_name target_base_name)
  string(TOUPPER ${target_base_name} target_base_name_upper)
  .
  .
  .
endmacro()

message(STATUS "Found the ${PACKAGE_NAME} import library: ${${package_name_upper}_IMPORT_LIB}")
message(STATUS "Found the ${PACKAGE_NAME} static library: ${${package_name_upper}_STATIC_LIB}")
endif()
endfunction()

arrow_show_details(arrow)

2 changes: 2 additions & 0 deletions cpp/src/arrow/ArrowTestingConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowTestingTargets.cmake")
arrow_keep_backward_compatibility(ArrowTesting arrow_testing)

check_required_components(ArrowTesting)

arrow_show_details(arrow_testing)
Comment thread
dhruv9vats marked this conversation as resolved.
Outdated
2 changes: 2 additions & 0 deletions cpp/src/arrow/dataset/ArrowDatasetConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowDatasetTargets.cmake")
arrow_keep_backward_compatibility(ArrowDataset arrow_dataset)

check_required_components(ArrowDataset)

arrow_show_details(arrow_dataset)
2 changes: 2 additions & 0 deletions cpp/src/arrow/engine/ArrowSubstraitConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowSubstraitTargets.cmake")
arrow_keep_backward_compatibility(ArrowSubstrait arrow_substrait)

check_required_components(ArrowSubstrait)

arrow_show_details(arrow_substrait)
2 changes: 2 additions & 0 deletions cpp/src/arrow/flight/ArrowFlightConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowFlightTargets.cmake")
arrow_keep_backward_compatibility(ArrowFlight arrow_flight)

check_required_components(ArrowFlight)

arrow_show_details(arrow_flight)
Comment thread
dhruv9vats marked this conversation as resolved.
Outdated
2 changes: 2 additions & 0 deletions cpp/src/arrow/flight/ArrowFlightTestingConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowFlightTestingTargets.cmake")
arrow_keep_backward_compatibility(ArrowFlightTetsing arrow_flight_testing)

check_required_components(ArrowFlightTesting)

arrow_show_details(arrow_flight_testing)
2 changes: 2 additions & 0 deletions cpp/src/arrow/flight/sql/ArrowFlightSqlConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowFlightSqlTargets.cmake")
arrow_keep_backward_compatibility(ArrowFlightSql arrow_flight_sql)

check_required_components(ArrowFlightSql)

arrow_show_details(arrow_flight_sql)
2 changes: 2 additions & 0 deletions cpp/src/arrow/gpu/ArrowCUDAConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowCUDATargets.cmake")
arrow_keep_backward_compatibility(ArrowCUDA arrow_cuda)

check_required_components(ArrowCUDA)

arrow_show_details(arrow_cuda)
2 changes: 2 additions & 0 deletions cpp/src/gandiva/GandivaConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/GandivaTargets.cmake")
arrow_keep_backward_compatibility(Gandiva gandiva)

check_required_components(Gandiva)

arrow_show_details(gandiva)
2 changes: 2 additions & 0 deletions cpp/src/parquet/ParquetConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ParquetTargets.cmake")
arrow_keep_backward_compatibility(Parquet parquet)

check_required_components(Parquet)

arrow_show_details(parquet)
2 changes: 2 additions & 0 deletions cpp/src/plasma/PlasmaConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/PlasmaTargets.cmake")
arrow_keep_backward_compatibility(Plasma plasma)

check_required_components(Plasma)

arrow_show_details(plasma)
2 changes: 2 additions & 0 deletions python/pyarrow/src/ArrowPythonConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowPythonTargets.cmake")
arrow_keep_backward_compatibility(ArrowPython arrow_python)

check_required_components(ArrowPython)

arrow_show_details(arrow_python)
Comment thread
dhruv9vats marked this conversation as resolved.
Outdated
2 changes: 2 additions & 0 deletions python/pyarrow/src/ArrowPythonFlightConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowPythonFlightTargets.cmake")
arrow_keep_backward_compatibility(ArrowPythonFlight arrow_python_flight)

check_required_components(ArrowPythonFlight)

arrow_show_details(arrow_python_flight)