Skip to content

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented Nov 19, 2017

No description provided.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending rebase. However, do we want to enable this in one of our Travis CI build entries?

Change-Id: I5842ff96c4198801659aa108768fe9bbef05e75b
@xhochy
Copy link
Member Author

xhochy commented Nov 21, 2017

I'm not sure if we have a free matrix entry anymore where we would be able to activate it again. I would like to (gradually) reintroduce jemalloc as the default again but we also should keep jemalloc-free builds in our test matrix.

@wesm
Copy link
Member

wesm commented Nov 21, 2017

Perhaps we can do it in one of the Linux builds for now. I'll merge this and we can deal with the reintroduction as the default in a separate patch

@wesm wesm closed this in 15ed080 Nov 21, 2017
@wesm wesm deleted the ARROW-1703 branch November 21, 2017 21:24
@wesm
Copy link
Member

wesm commented Nov 21, 2017

N.B. The problem with this vendoring strategy is that updates to jemalloc will bloat the repo size, where the vendoring procedure used in Redis and other projects would not. So if we end up needing to update jemalloc more than once in the future, we might check in the raw source directory so that incremental diffs don't cause a significant increase in repo size

@xhochy
Copy link
Member Author

xhochy commented Nov 22, 2017

I don't expect that we will update jemalloc often. Hopefully, we can use the stable 5.x release series soon and then use official builds everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants