ARROW-15800 [R] bindings for lubridate::as_date() and lubridate::as_datetime() - abandoned
#12677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dragosmg
force-pushed
the
lubridate_as_date_as_datetime
branch
from
f58d47c to
76803ee
Compare
jonkeane
requested changes
Mar 28, 2022
Member
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
This isn't really possible without a lot of extra work, but for the future: when moving lots of stuff around like this, it can be helpful to do the reorganization as either the first or the last commit, so that the real diff can be seen more easily.
For the stuff that is being moved around, you did just that, move them around without changing the functionality, yeah? The only new functionality is as_date, as_datetime and the corresponding tests, yeah?
dragosmg
changed the title
lubridate::as_date() and lubridate::as_datetime()lubridate::as_date() and lubridate::as_datetime() - abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: I have abandoned this PR. The work continues at #12738 and focuses solely on adding bindings for
as_date()andas_datetime().What is this PR trying to do:
lubridate::as_date()andlubridate::as_datetime()datetimebindings by:register_bindings_datetime_helpers()which brings together the datetime coercion functionsdifftimefunctions toregister_bindings_duration()