Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1499 commits
Select commit Hold shift + click to select a range
3f28b1e
Add tests to check authentication with token
jcralmeida Jan 25, 2022
1ef15f5
Add a method populateProperties on Authentication interface and refac…
jcralmeida Jan 26, 2022
ede0e63
Add a method to create a FlightServerTestRule with standard values an…
jcralmeida Jan 26, 2022
bf8722e
add try with resources on TokenAuthenticationTest
jcralmeida Jan 28, 2022
f440890
Add ClientCookieMiddleware to ArrowFlightSqlClientHandler
iurysalino Jan 31, 2022
3e5e986
Add test for the new functionality of handling cookies
iurysalino Jan 31, 2022
3bf0aab
Refactor cookie code
jcralmeida Jan 31, 2022
529a07d
Validate the cookies before insert it on server
jcralmeida Jan 31, 2022
9053892
Include `Statement` in the try with resources.
iurysalino Feb 2, 2022
8b2717a
Include `Statement` in the try with resources.
iurysalino Feb 2, 2022
51bb218
Clean up Cookies test
rafael-telles Feb 17, 2022
86b3021
Change Illegal Argument Exception to SQL Exception for Date, Time and…
escobargabriel Feb 24, 2022
3c1b1bb
Change Illegal Argument Exception to SQL Exception for varchar vector…
escobargabriel Mar 8, 2022
ed37fc6
Instantiate a checked function interface and change the calls on meth…
escobargabriel Mar 8, 2022
b60bec3
Remove unnecessary try catch
escobargabriel Mar 9, 2022
1a4df19
Apply checkstyle
escobargabriel Mar 9, 2022
2aa1a4d
Change expected exception to SQL Exception
escobargabriel Mar 9, 2022
6c604a0
Remove extra line
escobargabriel Mar 9, 2022
ce6b1a2
Change unsupported operation exception to SQL exception
escobargabriel Mar 9, 2022
11dcd60
Make getOperationSupported return a SQL Exception
escobargabriel Mar 9, 2022
4d7edb1
Remove extra line
escobargabriel Mar 10, 2022
011bdcb
Change getBytes Tests Failures about Binary Data Conversion
iurysalino Mar 9, 2022
80b010f
Change `iterate` to use the interface CheckedFunction.
iurysalino Mar 11, 2022
6274b69
Add Interface `CheckedFunction` and create a method `assertAccessorGe…
iurysalino Mar 11, 2022
5c375c7
Change Tests to use `assertAccessorGetterForException` for Throws SQL…
iurysalino Mar 11, 2022
ae145d6
Adjusted indentation `noOpWasNullConsumer`
iurysalino Mar 11, 2022
4d6afb1
Change method name `assertAccessorGetterForException` to `assertAcces…
iurysalino Mar 11, 2022
3caa38e
Removed prefix in the `CheckedFunction`
iurysalino Mar 11, 2022
8b30b02
Removed prefix in the `CheckedFunction` and change import
iurysalino Mar 11, 2022
425d6da
Inform message in to SQLException
iurysalino Mar 11, 2022
b62cefa
Remove redundant test.
iurysalino Mar 11, 2022
9c3311e
Remove blank line
iurysalino Mar 11, 2022
d4f0664
Adjust style text
iurysalino Mar 11, 2022
9c3a0f5
Remove method getBytes.
iurysalino Mar 11, 2022
dc13aba
Refactor Tests Failures With Boolean Data Conversion `ResultSet.getBo…
iurysalino Mar 9, 2022
075e92f
Revert Change in to `getOperationNotSupported`
iurysalino Mar 9, 2022
b4b1196
Change ´UnsupportedOperationException´ message
iurysalino Mar 9, 2022
5d49b6f
Add Message to `SQLException`
iurysalino Mar 9, 2022
fccbd13
Revert changes about `interface Getter`
iurysalino Mar 9, 2022
817dad3
Change `assertGetBoolean` to `assertGetBooleanForSQLException`
iurysalino Mar 9, 2022
6b540c9
Adjust text message in the throw SQLException
iurysalino Mar 11, 2022
4afb631
Fix text in to SQLException
iurysalino Mar 11, 2022
09ec278
Changed test names in to `ArrowFlightJdbcVarCharVectorAccessorTest`
iurysalino Mar 11, 2022
2e30866
Adjusted name test methods.
iurysalino Mar 14, 2022
d248e3e
Use Avatica DateTimeUtils for getString in Date/Time (#7)
vfraga Mar 15, 2022
a471438
Remove dependencies of deprecated class `UrlSample` and `PropertiesSa…
iurysalino Feb 25, 2022
55fdd48
Remove deprecated classes `UrlSample` and `Properties`
iurysalino Feb 25, 2022
d8f8d8f
WIP Refactor Deprecated Classes.
iurysalino Mar 8, 2022
c766b50
Remove Deprecated Class `FlightTestUtils`.
iurysalino Mar 17, 2022
5bbe84d
WIP - Refactor Tests Using TLS Connection
iurysalino Mar 18, 2022
7baead4
Refactor apply method `FlightServerTestRule` for use TLS connection.
iurysalino Mar 21, 2022
9bf9f65
Remove FindBug Dependency.
iurysalino Mar 21, 2022
615d865
Remove unused methods `validade` and `validade2`
iurysalino Mar 21, 2022
2b36c36
Remove not necessary parameters for connection.
iurysalino Mar 21, 2022
5c1a9e7
Remove not necessary import
iurysalino Mar 21, 2022
41a66e4
Create ´getPort´and ´getHost´ methods.
iurysalino Mar 21, 2022
25e7c48
Remove unused parameters.
iurysalino Mar 21, 2022
124247f
Created `initiateServer` method to reduce redundancy of code.
iurysalino Mar 22, 2022
1040ee0
Extract `user` and `pass` for variables.
iurysalino Mar 22, 2022
b78ce73
Add `getPort` and `getHost` Javadoc.
iurysalino Mar 22, 2022
c2f0a59
Remove Blank Line.
iurysalino Mar 22, 2022
dcbe95e
Add support for getUnicodeStream for Text and Binary accessors (#16)
vfraga Mar 23, 2022
aecf26c
Create `FlightCerts` for reference certificates localed in `testing/d…
iurysalino Mar 22, 2022
71799f0
Move methods reference certificates localed in `testing/data/flight` …
iurysalino Mar 22, 2022
c43843c
Remove local certificated files.
iurysalino Mar 22, 2022
c72e1c8
Refactor `ConnectionTlsTest` to use `FlightServerTestRule` and `Fligh…
iurysalino Mar 22, 2022
27bd5df
Add plugin configuration to reference the folder where are the certif…
iurysalino Mar 22, 2022
0131706
Move `CertKeyPair` for `FlightSqlTestCertificates`
iurysalino Mar 23, 2022
f8f5351
Rename `FlightCerts` to `FlightSqlTestCertificates`
iurysalino Mar 23, 2022
97ef16e
Move `CertKeyPair` class to `FlightSqlTestCertificates`
iurysalino Mar 23, 2022
c7ec964
Changed the `builder.setType` for on the`setName` send `fieldType` co…
iurysalino Mar 23, 2022
bf99507
Changed this test to compare parameters with SqlTypes.
iurysalino Mar 23, 2022
7136297
Address all JDBC ratification comments with small fixes #1 (#14)
vfraga Mar 23, 2022
59148df
Add license to spotbugs exclusion xml and better shading filter for org.
vfraga Mar 25, 2022
293b949
Fix rebase automerge
vfraga Mar 29, 2022
7ded42a
Temporarily fix MockFlightSqlProducer - implementation needed
vfraga Mar 29, 2022
0ec7155
Add missing module of flight-jdbc-driver to pom.xml
jcralmeida Mar 29, 2022
b206219
Add parameters to disable certificate verification
jcralmeida Mar 28, 2022
c6175fb
Pass the disableCertificationVerification to the client
jcralmeida Mar 28, 2022
4259e5f
Test disableCertificateVerificaiton on ConnectionTlsTest
jcralmeida Mar 28, 2022
0e6dba2
Set useTls default behavior as true
jcralmeida Mar 29, 2022
b1b5e4e
Refactor tests because of the new behavior of useTls default value as…
jcralmeida Mar 29, 2022
04adac3
Remove if statement on setUseTls
jcralmeida Mar 29, 2022
a03aa1e
Create the ColumnMetaData `TYPE_NAME`, and a `getTypeName` method, an…
iurysalino Mar 28, 2022
a11b76d
Create the metadata `TYPE_NAME`.
iurysalino Mar 28, 2022
126dbba
Add TYPE_NAME on C++
rafael-telles Mar 29, 2022
d758f5c
Merge pull request #23 from rafael-telles/ssl-without-certificate
jcralmeida Mar 30, 2022
14e979c
Add joda time dependency
escobargabriel Mar 31, 2022
b91080c
Add methods for format interval Day, Year and milliseconds from period
escobargabriel Mar 31, 2022
c811904
Change getString to use formatIntervalYear and formatIntervalDay methods
escobargabriel Mar 31, 2022
c3a1a6a
Change getString to use formatIntervalYear and formatIntervalDay methods
escobargabriel Mar 31, 2022
cc1144a
Merge remote-tracking branch 'origin/change-interval-behaviour-for-ge…
escobargabriel Mar 31, 2022
9ce9e32
Remove unnecessary dependency from integration tests
escobargabriel Mar 31, 2022
dffe661
Extract methods from ArrowFlightJdbcIntervalVectorAccessor class to u…
escobargabriel Mar 31, 2022
9f86ea9
Add tests with negative values for year and day intervals
escobargabriel Mar 31, 2022
c881c1c
Remove getBytes from remaining numeric types
vfraga Apr 1, 2022
942538a
Change class name and related imports
escobargabriel Apr 1, 2022
061bc3f
Apply the asserts to tests
escobargabriel Apr 1, 2022
199660f
Refactor jdbc tls connection to use trustStore correctly
jcralmeida Apr 4, 2022
57d6fb4
Create the column metadata `TYPE_NAME`.
iurysalino Apr 4, 2022
d151750
Implement the base for the tls connection using systemCertificate
jcralmeida Apr 5, 2022
86b9a13
Refactor useTls to ssl as parameter
jcralmeida Apr 6, 2022
49f7ff6
Add missing java docs to the ssl options
jcralmeida Apr 6, 2022
18ae06f
Refactor keyStore to trustStore on methods and variables
jcralmeida Apr 6, 2022
7b1de26
Change import order
jcralmeida Apr 6, 2022
46b5b1b
Remove unused import
jcralmeida Apr 6, 2022
b9303d5
Refactor by adding methods that check the operating system and one th…
jcralmeida Apr 6, 2022
d0cfeb7
Remove unnecessary test from ConnectionTlsTest
jcralmeida Apr 6, 2022
b48cc22
Remove unnecessary validation of useSystemTrustStore
jcralmeida Apr 6, 2022
1f309fd
Load a new Windows system keyStore
jcralmeida Apr 6, 2022
8cc2e6c
Change parameter format
escobargabriel Apr 6, 2022
0ecf090
fix getDate() and getTime() with null calendar parameter
Apr 7, 2022
39ace00
Add more test cases of day and year interval
escobargabriel Apr 7, 2022
8e8082e
fix getTimestamp()
Apr 7, 2022
1c5ed6e
Add typeName to testGetTablesResultFilteredWithSchema
escobargabriel Apr 8, 2022
f2dce9c
remove empty line
escobargabriel Apr 8, 2022
7bac8d2
Change IntervalStringUtils class to final
escobargabriel Apr 8, 2022
44796fa
Merge pull request #26 from rafael-telles/change-interval-behaviour-f…
rafael-telles Apr 8, 2022
cc03378
Rename keyStore to trustStore in ArrowFlightSqlClientHandler
jcralmeida Apr 8, 2022
d978b13
Remove unnecessary method to check is the system is linux
jcralmeida Apr 8, 2022
84ab518
Refactor method to read systemTrustCertificates
jcralmeida Apr 8, 2022
11906d7
Refactor ConnectionTlsTest to set useSystemCertificate to false
jcralmeida Apr 8, 2022
42bbef5
Change top order of the if statement in the build method from ArrowFl…
jcralmeida Apr 11, 2022
d851ef5
Add @Visible for testing on methods from ClientAuthenticationUtils
jcralmeida Apr 11, 2022
0a827ab
Fix findbug errors on ClientAuthenticationUtils
jcralmeida Apr 11, 2022
d0d6b35
Fix tests due to the changes from the ssl default values as true and …
jcralmeida Apr 11, 2022
0fa843b
Add more test for the ClientAuthenticationUtilsTest class
jcralmeida Apr 11, 2022
4311bfa
Merge pull request #27 from rafael-telles/tls-truststore-fix
jcralmeida Apr 11, 2022
f6ac593
Merge branch 'apache:master' into flight-jdbc-driver
jduo Apr 12, 2022
98d4e73
Test if type is null
escobargabriel Apr 12, 2022
299392c
fix the case when Timestamp has a timezone
Apr 14, 2022
d033a99
UT rearranged
Apr 15, 2022
00808c0
Update java/flight/flight-jdbc-driver/src/test/java/org/apache/arrow/…
Eugene-Roslikov-BQ Apr 18, 2022
7924e7b
Merge pull request #29 from rafael-telles/Timestamp_fix
rafael-telles Apr 18, 2022
e6d01af
Change ssl parameter to UseEncryption
jcralmeida Apr 19, 2022
55eeed9
Merge pull request #32 from rafael-telles/change-ssl-parameter-to-use…
jcralmeida Apr 19, 2022
820f07a
Add column metadata when executing Statement
vfraga Apr 20, 2022
629988c
Remove wildcard import in FlightServerTestRule
vfraga Apr 20, 2022
32dbc66
Fix incorrect rename from useTls#FlightServer.Builder call
jcralmeida Apr 20, 2022
8494d09
Update tests for GetTables -- start refactor to use proper schemas
Jul 16, 2021
4af42ed
Flight SQL Ratification Based On Community Feedback #7 (#98)
rafael-telles Aug 26, 2021
1ea5e62
Fix maven build from different directories (#114)
rafael-telles Sep 3, 2021
a9d539d
Add CrossReference methods to SqlProducer
jcralmeida Oct 18, 2021
8f816b7
Create a module for keeping all Arrow Flight-related submodules
Jun 4, 2021
bd832a7
Fix checkstyle violations in Arrow Flight JDBC Driver
Jun 4, 2021
6164e47
Create a module for keeping all Arrow Flight-related submodules
Jun 4, 2021
e926b5e
Fix checkstyle violations in Arrow Flight JDBC Driver
Jun 4, 2021
6ea242d
Create a module for keeping all Arrow Flight-related submodules
Jun 4, 2021
49fec26
Fix checkstyle violations in Arrow Flight JDBC Driver
Jun 4, 2021
bd0bc59
Create a module for keeping all Arrow Flight-related submodules
Jun 4, 2021
5df0b7c
Fix checkstyle violations in Arrow Flight JDBC Driver
Jun 4, 2021
647eed7
Fix rebase issues
vfraga Oct 28, 2021
e8e7512
Add missing metadata on Arrow schemas returned by Flight SQL's GetTab…
rafael-telles Dec 9, 2021
5c67e9e
Change unsupported operation exception to SQL exception
escobargabriel Mar 9, 2022
ac6f516
Make getOperationSupported return a SQL Exception
escobargabriel Mar 9, 2022
a6ca630
Address all ratification comments with small fixes
vfraga Mar 14, 2022
e54c4d4
Small fixes
vfraga Mar 14, 2022
59d157a
Revert small changes
vfraga Mar 14, 2022
3d8d454
Change UnsupportedOperationException to SQLException
vfraga Mar 14, 2022
dc85668
Address all ratification comments with small fixes
vfraga Mar 14, 2022
9c629c5
Fix failing tests
vfraga Mar 16, 2022
1169d25
Address to James' review
vfraga Mar 16, 2022
f889488
Removed some suppressions by creating newChildAllocators
vfraga Mar 16, 2022
dd55ab2
Fix CONNECTION_STRING_EXPECTED
vfraga Mar 16, 2022
d27e460
nit on CONNECTION_STRING_EXPECTED
vfraga Mar 16, 2022
8b235fc
Address more review comments
vfraga Mar 21, 2022
54e5d89
nit on holder comment
vfraga Mar 21, 2022
ce367c0
Parse server-side parameters
vfraga Feb 14, 2022
51f19d5
Fix coverage tests after changing URL parsing
vfraga Feb 14, 2022
5252937
Properly avoid shading of Flight JDBC Properties
vfraga Feb 15, 2022
3f814d8
Rebase with flight-jdbc-driver
vfraga Mar 24, 2022
be1e7fa
Fix rebase automerge
vfraga Mar 29, 2022
baf0ed7
Replace the semicolons instead of removing and adding to properties
vfraga Mar 30, 2022
e650d56
Add temporary debugging to connection strings and properties
vfraga Mar 30, 2022
aefbbf9
Add temporary debugging for connection properties in query execution
vfraga Mar 30, 2022
01225d7
Remove logging
vfraga Apr 4, 2022
f2a3157
Update tests for GetTables -- start refactor to use proper schemas
Jul 16, 2021
0de5a28
Flight SQL Ratification Based On Community Feedback #7 (#98)
rafael-telles Aug 26, 2021
35c676a
Fix maven build from different directories (#114)
rafael-telles Sep 3, 2021
2536e57
Add CrossReference methods to SqlProducer
jcralmeida Oct 18, 2021
3ad80b9
Create a module for keeping all Arrow Flight-related submodules
Jun 4, 2021
16f291b
Fix checkstyle violations in Arrow Flight JDBC Driver
Jun 4, 2021
3d2eeae
Create a module for keeping all Arrow Flight-related submodules
Jun 4, 2021
21aa3d9
Fix checkstyle violations in Arrow Flight JDBC Driver
Jun 4, 2021
86659d3
Create a module for keeping all Arrow Flight-related submodules
Jun 4, 2021
adb5be7
Fix checkstyle violations in Arrow Flight JDBC Driver
Jun 4, 2021
9b1bb79
Create a module for keeping all Arrow Flight-related submodules
Jun 4, 2021
18632fe
Fix checkstyle violations in Arrow Flight JDBC Driver
Jun 4, 2021
0e0c245
Fix rebase issues
vfraga Oct 28, 2021
877d235
Add missing metadata on Arrow schemas returned by Flight SQL's GetTab…
rafael-telles Dec 9, 2021
db401f5
Change unsupported operation exception to SQL exception
escobargabriel Mar 9, 2022
d3601d1
Make getOperationSupported return a SQL Exception
escobargabriel Mar 9, 2022
29ef79d
Address all ratification comments with small fixes
vfraga Mar 14, 2022
2e4e4ba
Small fixes
vfraga Mar 14, 2022
e67b4ea
Revert small changes
vfraga Mar 14, 2022
aba4d4e
Change UnsupportedOperationException to SQLException
vfraga Mar 14, 2022
2b6b1de
Address all ratification comments with small fixes
vfraga Mar 14, 2022
fecd606
Fix failing tests
vfraga Mar 16, 2022
adc22a3
Address to James' review
vfraga Mar 16, 2022
e016d9e
Removed some suppressions by creating newChildAllocators
vfraga Mar 16, 2022
ceceb59
Fix CONNECTION_STRING_EXPECTED
vfraga Mar 16, 2022
963ecb6
nit on CONNECTION_STRING_EXPECTED
vfraga Mar 16, 2022
868ada2
Address more review comments
vfraga Mar 21, 2022
488dced
nit on holder comment
vfraga Mar 21, 2022
3df6452
Parse server-side parameters
vfraga Feb 14, 2022
2cf976b
Fix coverage tests after changing URL parsing
vfraga Feb 14, 2022
31626dd
Properly avoid shading of Flight JDBC Properties
vfraga Feb 15, 2022
6847812
Rebase with flight-jdbc-driver
vfraga Mar 24, 2022
24663c4
Fix rebase automerge
vfraga Mar 29, 2022
30733d7
Replace the semicolons instead of removing and adding to properties
vfraga Mar 30, 2022
0f643db
Add temporary debugging to connection strings and properties
vfraga Mar 30, 2022
8063bbe
Add temporary debugging for connection properties in query execution
vfraga Mar 30, 2022
dc7c91f
Fix rebase automerge
vfraga Apr 4, 2022
55c8b8f
Fix failing tests
vfraga Apr 4, 2022
5b3a53d
Fix statement missing column metadata
vfraga Apr 13, 2022
5baf234
Fix coverage
vfraga Apr 13, 2022
53b85fd
Fix rebase
vfraga Apr 19, 2022
74e66a1
Fix rebase
vfraga Apr 20, 2022
95a00f5
Add temporary fix for JdbcArray#toString
vfraga Apr 20, 2022
ee3c30c
Remove JdbcArray temporary fix
vfraga Apr 20, 2022
5f54c24
Implement toString
jvictorhuguenin Apr 20, 2022
f4b71c9
Fix string format
jvictorhuguenin Apr 20, 2022
e7b15d2
Change mapping type from STRUCT to JAVA Object
jcralmeida Apr 19, 2022
36ff017
Fix test that map arrows vector to jdbc types
jcralmeida Apr 19, 2022
36b43c9
Fix checkstyle
jvictorhuguenin Apr 21, 2022
f24ef45
Merge pull request #33 from rafael-telles/parse-connection-string
jcralmeida Apr 22, 2022
c1e0cc3
Ensure minimum ArrayList size.
jvictorhuguenin Apr 22, 2022
e2fee64
Merge pull request #35 from rafael-telles/to-string-array-jdbc-review
jcralmeida Apr 22, 2022
4883821
Merge pull request #37 from rafael-telles/fix-struct-type-on-jdbc
jcralmeida Apr 26, 2022
80148b7
Datetime fixes for regression (#36)
vfraga Apr 27, 2022
e745372
Change VarCharAccessor Getter to Bytes rather than Text (#38)
vfraga Apr 27, 2022
5f07a0e
Change getMillisReprValue to greater or equals
vfraga Apr 27, 2022
792a29c
Fix query exception message
jvictorhuguenin Apr 28, 2022
55fc9a1
Change the behavior to return the correct format for day and year int…
escobargabriel May 4, 2022
133d809
Test if holder.isSet indicates the value is null and return null dire…
escobargabriel May 5, 2022
6347675
Change the getString and getObject methods
escobargabriel May 5, 2022
bd16af2
Include a test passing a Joda object
escobargabriel May 5, 2022
7f09eb0
Remove checkstyle problem
escobargabriel May 5, 2022
7f1eeec
Merge pull request #40 from rafael-telles/fix-day-and-year-interval-f…
escobargabriel May 5, 2022
e383cef
Merge pull request #39 from rafael-telles/fix-exception-messages
rafael-telles May 9, 2022
c9b722d
Merge pull request #30 from rafael-telles/flight-jdbc-driver-create-m…
rafael-telles May 10, 2022
c9cdcac
Temporarily disable Spotbugs
vfraga May 24, 2022
360ee52
Fix attributes as headers bug and token value parsing error
jvictorhuguenin Jul 27, 2022
d66a60a
Fix crash for empty properties on the url
jvictorhuguenin Jul 27, 2022
1da5ba8
Merge pull request #43 from rafael-telles/fix-all-attributes-as-headers
jvictorhuguenin Jul 28, 2022
e22f7e4
Implement case insensitive for the property keys
jvictorhuguenin Jul 30, 2022
b2af3a0
Fix property lowercasing only for the connection string
jvictorhuguenin Aug 2, 2022
6eb3cfa
Add unit tests and fix possible crash on the parser
jvictorhuguenin Aug 3, 2022
220e844
Merge pull request #44 from rafael-telles/implement-case-insensitive
jvictorhuguenin Aug 3, 2022
6c8a900
Fix checkstyle issues
vfraga Aug 4, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cpp/src/arrow/flight/sql/column_metadata.cc
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ bool StringToBoolean(const std::string& string_value) {
const char* ColumnMetadata::kCatalogName = "ARROW:FLIGHT:SQL:CATALOG_NAME";
const char* ColumnMetadata::kSchemaName = "ARROW:FLIGHT:SQL:SCHEMA_NAME";
const char* ColumnMetadata::kTableName = "ARROW:FLIGHT:SQL:TABLE_NAME";
const char* ColumnMetadata::kTypeName = "ARROW:FLIGHT:SQL:TYPE_NAME";
const char* ColumnMetadata::kPrecision = "ARROW:FLIGHT:SQL:PRECISION";
const char* ColumnMetadata::kScale = "ARROW:FLIGHT:SQL:SCALE";
const char* ColumnMetadata::kIsAutoIncrement = "ARROW:FLIGHT:SQL:IS_AUTO_INCREMENT";
Expand All @@ -65,6 +66,10 @@ arrow::Result<std::string> ColumnMetadata::GetTableName() const {
return metadata_map_->Get(kTableName);
}

arrow::Result<std::string> ColumnMetadata::GetTypeName() const {
return metadata_map_->Get(kTypeName);
}

arrow::Result<int32_t> ColumnMetadata::GetPrecision() const {
std::string precision_string;
ARROW_ASSIGN_OR_RAISE(precision_string, metadata_map_->Get(kPrecision));
Expand Down Expand Up @@ -130,6 +135,12 @@ ColumnMetadata::ColumnMetadataBuilder& ColumnMetadata::ColumnMetadataBuilder::Ta
return *this;
}

ColumnMetadata::ColumnMetadataBuilder& ColumnMetadata::ColumnMetadataBuilder::TypeName(
std::string& type_name) {
metadata_map_->Append(ColumnMetadata::kTypeName, type_name);
return *this;
}

ColumnMetadata::ColumnMetadataBuilder& ColumnMetadata::ColumnMetadataBuilder::Precision(
int32_t precision) {
metadata_map_->Append(ColumnMetadata::kPrecision, std::to_string(precision));
Expand Down
24 changes: 18 additions & 6 deletions cpp/src/arrow/flight/sql/column_metadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ class ColumnMetadata {
static const char* kTableName;
/// \brief Constant variable to hold the value of the key that
/// will be used in the KeyValueMetadata class.
static const char* kTypeName;
/// \brief Constant variable to hold the value of the key that
/// will be used in the KeyValueMetadata class.
static const char* kPrecision;
/// \brief Constant variable to hold the value of the key that
/// will be used in the KeyValueMetadata class.
Expand Down Expand Up @@ -78,6 +81,10 @@ class ColumnMetadata {
/// \return The table name.
arrow::Result<std::string> GetTableName() const;

/// \brief Return the type name set in the KeyValueMetadata.
/// \return The type name.
arrow::Result<std::string> GetTypeName() const;

/// \brief Return the precision set in the KeyValueMetadata.
/// \return The precision.
arrow::Result<int32_t> GetPrecision() const;
Expand Down Expand Up @@ -117,15 +124,20 @@ class ColumnMetadata {
ColumnMetadataBuilder& CatalogName(std::string& catalog_name);

/// \brief Set the schema_name in the KeyValueMetadata object.
/// \param[in] schema_name The schema_name.
/// \param[in] schema_name The schema_name.
/// \return A ColumnMetadataBuilder.
ColumnMetadataBuilder& SchemaName(std::string& schema_name);

/// \brief Set the table name in the KeyValueMetadata object.
/// \param[in] table_name The table name.
/// \param[in] table_name The table name.
/// \return A ColumnMetadataBuilder.
ColumnMetadataBuilder& TableName(std::string& table_name);

/// \brief Set the type name in the KeyValueMetadata object.
/// \param[in] type_name The type name.
/// \return A ColumnMetadataBuilder.
ColumnMetadataBuilder& TypeName(std::string& type_name);

/// \brief Set the precision in the KeyValueMetadata object.
/// \param[in] precision The precision.
/// \return A ColumnMetadataBuilder.
Expand All @@ -138,22 +150,22 @@ class ColumnMetadata {

/// \brief Set the IsAutoIncrement in the KeyValueMetadata object.
/// \param[in] is_auto_increment The IsAutoIncrement.
/// \return A ColumnMetadataBuilder.
/// \return A ColumnMetadataBuilder.
ColumnMetadataBuilder& IsAutoIncrement(bool is_auto_increment);

/// \brief Set the IsCaseSensitive in the KeyValueMetadata object.
/// \param[in] is_case_sensitive The IsCaseSensitive.
/// \return A ColumnMetadataBuilder.
/// \return A ColumnMetadataBuilder.
ColumnMetadataBuilder& IsCaseSensitive(bool is_case_sensitive);

/// \brief Set the IsReadOnly in the KeyValueMetadata object.
/// \param[in] is_read_only The IsReadOnly.
/// \return A ColumnMetadataBuilder.
/// \return A ColumnMetadataBuilder.
ColumnMetadataBuilder& IsReadOnly(bool is_read_only);

/// \brief Set the IsSearchable in the KeyValueMetadata object.
/// \param[in] is_searchable The IsSearchable.
/// \return A ColumnMetadataBuilder.
/// \return A ColumnMetadataBuilder.
ColumnMetadataBuilder& IsSearchable(bool is_searchable);

ColumnMetadata Build() const;
Expand Down
3 changes: 3 additions & 0 deletions format/FlightSql.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1118,6 +1118,7 @@ message CommandGetDbSchemas {
* - ARROW:FLIGHT:SQL:CATALOG_NAME - Table's catalog name
* - ARROW:FLIGHT:SQL:DB_SCHEMA_NAME - Database schema name
* - ARROW:FLIGHT:SQL:TABLE_NAME - Table name
* - ARROW:FLIGHT:SQL:TYPE_NAME - Type name
* - ARROW:FLIGHT:SQL:PRECISION - Column precision/size
* - ARROW:FLIGHT:SQL:SCALE - Column scale/decimal digits if applicable
* - ARROW:FLIGHT:SQL:IS_AUTO_INCREMENT - "1" indicates if the column is auto incremented, "0" otherwise.
Expand Down Expand Up @@ -1457,6 +1458,7 @@ message ActionClosePreparedStatementRequest {
* - ARROW:FLIGHT:SQL:CATALOG_NAME - Table's catalog name
* - ARROW:FLIGHT:SQL:DB_SCHEMA_NAME - Database schema name
* - ARROW:FLIGHT:SQL:TABLE_NAME - Table name
* - ARROW:FLIGHT:SQL:TYPE_NAME - Type name
* - ARROW:FLIGHT:SQL:PRECISION - Column precision/size
* - ARROW:FLIGHT:SQL:SCALE - Column scale/decimal digits if applicable
* - ARROW:FLIGHT:SQL:IS_AUTO_INCREMENT - "1" indicates if the column is auto incremented, "0" otherwise.
Expand Down Expand Up @@ -1491,6 +1493,7 @@ message TicketStatementQuery {
* - ARROW:FLIGHT:SQL:CATALOG_NAME - Table's catalog name
* - ARROW:FLIGHT:SQL:DB_SCHEMA_NAME - Database schema name
* - ARROW:FLIGHT:SQL:TABLE_NAME - Table name
* - ARROW:FLIGHT:SQL:TYPE_NAME - Type name
* - ARROW:FLIGHT:SQL:PRECISION - Column precision/size
* - ARROW:FLIGHT:SQL:SCALE - Column scale/decimal digits if applicable
* - ARROW:FLIGHT:SQL:IS_AUTO_INCREMENT - "1" indicates if the column is auto incremented, "0" otherwise.
Expand Down
40 changes: 40 additions & 0 deletions java/flight/flight-jdbc-driver/jdbc-spotbugs-exclude.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
license agreements. See the NOTICE file distributed with this work for additional
information regarding copyright ownership. The ASF licenses this file to
You under the Apache License, Version 2.0 (the "License"); you may not use
this file except in compliance with the License. You may obtain a copy of
the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
by applicable law or agreed to in writing, software distributed under the
License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
OF ANY KIND, either express or implied. See the License for the specific
language governing permissions and limitations under the License. -->

<FindBugsFilter>
<!-- These elements are supposed to be mutable -->
<Match>
<Package name="~org\.apache\.arrow\.driver\.jdbc\.accessor\.impl.*"/>
<Bug pattern="EI_EXPOSE_REP2"/>
</Match>
<Match>
<Class name="org.apache.arrow.driver.jdbc.client.ArrowFlightSqlClientHandler"/>
<Bug pattern="EI_EXPOSE_REP2"/>
</Match>
<Match>
<Class name="org.apache.arrow.driver.jdbc.utils.ConnectionWrapper"/>
<Bug pattern="EI_EXPOSE_REP2"/>
</Match>
<Match>
<Class name="org.apache.arrow.driver.jdbc.ArrowFlightJdbcDataSource"/>
<Bug pattern="EI_EXPOSE_REP2"/>
</Match>
<Match>
<Class name="org.apache.arrow.driver.jdbc.ArrowFlightJdbcCursor"/>
<Bug pattern="EI_EXPOSE_REP2"/>
</Match>

<Match>
<Class name="org.apache.arrow.driver.jdbc.ArrowFlightJdbcDataSource"/>
<Bug pattern="EI_EXPOSE_REP"/>
</Match>
</FindBugsFilter>
Loading