Skip to content

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Jan 20, 2022

No description provided.

@github-actions
Copy link

@kszucs
Copy link
Member Author

kszucs commented Jan 20, 2022

Tested here #12187 (comment)

@kszucs kszucs closed this in df37b41 Jan 20, 2022
@ursabot
Copy link

ursabot commented Jan 20, 2022

Benchmark runs are scheduled for baseline = e9f9d40 and contender = df37b41. df37b41 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@domoritz
Copy link
Member

Good catch!

@kszucs
Copy link
Member Author

kszucs commented Jan 20, 2022

Good catch!

@domoritz Though we're still using node 14 in the linux builds which succeed. Shall we bump there as well [and in the release verification script]?

@domoritz
Copy link
Member

Oh interesting. I think the issue is that only the latest versions of Node 14 work reliably so it's best to just bump to Node 16 to make sure we have a consistent environment for the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants