ARROW-14821: [R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date#12154

Merged

nealrichardson merged 87 commits intoapache:masterfrom

djnavarro:ARROW-14281

Jul 21, 2022

Commits on Jul 13, 2022

adds round_temporal to make_compute_options

djnavarro
authored and
rok
committed
adds minimal round_temporal() implementation

djnavarro
authored and
rok
committed
registers date_round as a dplyr binding

djnavarro
authored and
rok
committed
support multiple option to round_temporal

djnavarro
authored and
rok
committed
support integer multiples in round_date() unit argument

djnavarro
authored and
rok
committed
use base::is.na

djnavarro
authored and
rok
committed
adds floor_date() and ceiling_date() bindings

djnavarro
authored and
rok
committed
adds failing tests

djnavarro
authored and
rok
committed
enforces maximum multiple for seconds, minutes and hours

djnavarro
authored and
rok
committed
support lubridate syntax for rounding to fractional seconds

djnavarro
authored and
rok
committed
date rounding tests mirror lubridate prior to v1.6.0

djnavarro
authored and
rok
committed
simplified datetime tests

djnavarro
authored and
rok
committed
tidy notes

djnavarro
authored and
rok
committed
moves test_df_v2 to top

djnavarro
authored and
rok
committed
allows rounding unit to exceed 60sec, 60min, 24hr

djnavarro
authored and
rok
committed
close parenthesis

djnavarro
authored and
rok
committed
spaces after "if"

djnavarro
authored and
rok
committed
restore lubridate defaults for unit thresholds

djnavarro
authored and
rok
committed
tests lubridate rounding thresholds more directly

djnavarro
authored and
rok
committed
use testdate + 1 in test

djnavarro
authored and
rok
committed
binding arguments mirror lubridate arguments

djnavarro
authored and
rok
committed
do not attempt to round to "week" units

djnavarro
authored and
rok
committed
remove todo comment

djnavarro
authored and
rok
committed
skip timezone dependent tests on windows

djnavarro
authored and
rok
committed
skips more timezone-dependent tests on windows sigh

djnavarro
authored and
rok
committed
skips all date/time rounding tests on windows

djnavarro
authored and
rok
committed
sets change_on_boundary = FALSE for ceiling_time tests

djnavarro
authored and
rok
committed
change_on_boundary=TRUE works for special case of 1 day

djnavarro
authored and
rok
committed
support change_on_boundary=TRUE for datetimes below "month" units

djnavarro
authored and
rok
committed
minimal test for desired date behaviour for change_on_boundary = TRUE

djnavarro
authored and
rok
committed
Add change_on_boundary to RoundTemporalOptions
rok
committed
Update r/src/compute.cpp

djnavarro
and
rok
committed
support change_on_boundary

djnavarro
authored and
rok
committed
removes unneeded code

djnavarro
authored and
rok
committed
fix change on boundary bug

djnavarro
authored and
rok
committed
updates tests

djnavarro
authored and
rok
committed
minimal support for round to week

djnavarro
authored and
rok
committed
attempt to fix linting issue

djnavarro
authored and
rok
committed
fix whitespace

djnavarro
authored and
rok
committed
extends ceiling_date tests

djnavarro
authored and
rok
committed
isolates strangeness with date arrays

djnavarro
authored and
rok
committed
change_on_boundary -> ceil_is_strictly_greater
rok
committed
isolates last remaining issue with change_on_boundary to possible floating point problem

djnavarro
authored and
rok
committed
ceiling_date and floor_date support "week" units for week start 1 and 7

djnavarro
authored and
rok
committed
week_start values 2:6 work for datetimes (but not dates)

djnavarro
authored and
rok
committed
leap_year calls is_leap_year directly

djnavarro
authored and
rok
committed
week_starts_monday, ceil_is_strictly_greater, and calendar_based_origin all boolean

djnavarro
authored and
rok
committed
removes skip_on_windows

djnavarro
authored and
rok
committed
reorganise tests

djnavarro
authored and
rok
committed
bypass lubridate round-to-week bug on round_date tests

djnavarro
authored and
rok
committed
shift_date32_to_week and shift_timestamp_to_week added for case when rounding unit is week with non-standard week_start

djnavarro
authored and
rok
committed
linting fix

djnavarro
and
rok
committed
fix another linting issue

djnavarro
authored and
rok
committed
even more linting fixes

djnavarro
authored and
rok
committed
groups datetime rounding functions together

djnavarro
authored and
rok
committed
moves all round/floor/ceil-to-week to shift_temoporal_to_week

djnavarro
authored and
rok
committed
removes redundant binding

djnavarro
and
rok
committed
sigh

djnavarro
authored and
rok
committed
tidies date rounding functions

djnavarro
authored and
rok
committed
removes unneeded skips and adds test comments

djnavarro
authored and
rok
committed
reorganises temporal rounding unit tests

djnavarro
authored and
rok
committed
checks wider range of boundaries for ceiling_time

djnavarro
authored and
rok
committed
restores failing tests for month/quarter/year

djnavarro
authored and
rok
committed
temporarily removes all datetime rounding tests

djnavarro
authored and
rok
committed
restores datetime rounding tests

djnavarro
authored and
rok
committed
fixes linting issues

djnavarro
authored and
rok
committed
attaches timezone attribute correctly for year_of_dates test object

djnavarro
authored and
rok
committed
tests week/month/year rounding for Dates bypassing lubridate bug

djnavarro
authored and
rok
committed
tests for rounding in local time

djnavarro
authored and
rok
committed
don't link directly to lubridate issue

djnavarro
authored and
rok
committed
adds Pacific/Marquesas and Asia/Kathmandu timezones

djnavarro
authored and
rok
committed
adds more timezone tests

djnavarro
authored and
rok
committed
restricts timezone test cases on windows os

djnavarro
authored and
rok
committed
removes trailing whitespace

djnavarro
authored and
rok
committed
adds missing test: timezone check for round to week

djnavarro
authored and
rok
committed
fixes date strings test bug

djnavarro
authored and
rok
committed
bypasses esoteric lubridate timezone-local rounding bug and adds an internal consistency test of timezone-local rounding

djnavarro
authored and
rok
committed
adds internal consistency tests for timezone-local rounding to multiple-unit periods

djnavarro
authored and
rok
committed
sigh. don't test subsecond rounding with test that isn't designed to test subsecond rounding \facepalm

djnavarro
authored and
rok
committed
Removing ARROW-16412 workarounds
rok
committed

Commits on Jul 20, 2022