Skip to content

ARROW-15165: [Python] Expose function to resolve S3 bucket region #11998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pitrou wants to merge 2 commits into from
Closed

ARROW-15165: [Python] Expose function to resolve S3 bucket region #11998

pitrou wants to merge 2 commits into from

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Dec 20, 2021

No description provided.

@pitrou pitrou marked this pull request as draft December 20, 2021 16:32
@pitrou
Copy link
Member Author

pitrou commented Dec 20, 2021

Based on PR #11997

@github-actions
Copy link

github-actions bot commented Dec 20, 2021

https://issues.apache.org/jira/browse/ARROW-15165

@pitrou pitrou force-pushed the ARROW-15165-py-s3-resolve-region branch from f679f93 to 62c8d3b Compare December 20, 2021 19:59
@pitrou pitrou marked this pull request as ready for review December 20, 2021 19:59
@pitrou
Copy link
Member Author

pitrou commented Dec 21, 2021

Also cc @amol-

amol-
amol- reviewed Dec 21, 2021
View reviewed changes
python/pyarrow/_s3fs.pyx
check_status(CFinalizeS3())


def resolve_s3_region(bucket):
Copy link
Member

@amol- amol- Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to docs/api/filesystems.rst ?

Copy link
Member Author

@pitrou pitrou Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll do it.

jorisvandenbossche
jorisvandenbossche reviewed Dec 23, 2021
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ursabot
Copy link

ursabot commented Dec 23, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = 8e4038b and contender = e60e6b0. e60e6b0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] ursa-i9-9960x
[Failed ⬇️0.04% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@pitrou pitrou deleted the ARROW-15165-py-s3-resolve-region branch December 26, 2021 17:29
@asfimport asfimport mentioned this pull request Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amol- amol- amol- left review comments

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees

No one assigned

Labels

Component: C++ Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou @ursabot @amol- @jorisvandenbossche