Skip to content

Conversation

@jorisvandenbossche
Copy link
Member

No description provided.

@github-actions
Copy link

@jorisvandenbossche
Copy link
Member Author

Small follow-up on #11283 to improve the styling (IMO) of the version dropdown. It puts the dropdown and search box sidee-by-side if there is enough space:

image

but will wrap around if not for narrow windows (with a minimum width for the search box):

image

@kszucs kszucs changed the title ARROW-14189: [Docs] Version dropdown side-by-side with search box ARROW-14499: [Docs] Version dropdown side-by-side with search box Oct 28, 2021
@github-actions
Copy link

@kszucs
Copy link
Member

kszucs commented Oct 28, 2021

Created a new JIRA for this, so the cherry-picking script for 6.0.1 can properly pick this up.

@jorisvandenbossche
Copy link
Member Author

Thanks! (I was actually wondering about that, should have asked)

@kszucs
Copy link
Member

kszucs commented Oct 28, 2021

Thanks! (I was actually wondering about that, should have asked)

The scripts expect one-to-one mapping between jiras and patches, so creating a new jira should be preferred.

@kszucs kszucs closed this in 08ed9ad Oct 28, 2021
@ursabot
Copy link

ursabot commented Oct 28, 2021

Benchmark runs are scheduled for baseline = 0f3e36e and contender = 08ed9ad. 08ed9ad is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.2% ⬆️0.13%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@jorisvandenbossche jorisvandenbossche deleted the ARROW-14189-version-dropdown-follow-up branch October 28, 2021 10:38
kszucs pushed a commit that referenced this pull request Nov 3, 2021
Closes #11563 from jorisvandenbossche/ARROW-14189-version-dropdown-follow-up

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Krisztián Szűcs <[email protected]>
kszucs pushed a commit that referenced this pull request Nov 4, 2021
Closes #11563 from jorisvandenbossche/ARROW-14189-version-dropdown-follow-up

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Krisztián Szűcs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants