ARROW-1511: [C++] Promote ArrayData, MakeArray to public API, deprecate MakePrimitiveArray #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I0090615f7554eda7c01201b309828db9c104def8
Change-Id: I4e7c9de65e5ceb94008d0c2be85463376ef451ec
Member
Author
|
@xhochy I didn't figure this would be controversial (since this was an internal API before) but have a look in case it affects turbodbc or anywhere else |
Member
Author
|
Test failure is due to the unrelated glib thing seen elsewhere |
xhochy
approved these changes
Sep 12, 2017
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1, should not break anything in turbodbc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ArrayDatawill become more exposed to users with the advent ofarrow::compute, it should be a part of the public API.