Skip to content

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented May 3, 2021

Disable the rust integration tests by default.

In order to execute the rust integration tests as well pass ARCHERY_INTEGRATION_WITH_RUST=1 environment variable to the docker container.

@github-actions
Copy link

github-actions bot commented May 3, 2021

@kszucs kszucs requested a review from pitrou May 3, 2021 14:04
@pitrou
Copy link
Member

pitrou commented May 3, 2021

This doesn't seem to be sufficient. I get the following error (multiple times):

==========================================================
Testing file /tmp/arrow-integration-_9i6ftux/generated_null_trivial.json
==========================================================
-- Creating binary inputs
-- Validating file
Traceback (most recent call last):
  File "/arrow/dev/archery/archery/integration/runner.py", line 213, in _run_ipc_test_case
    run_binaries(producer, consumer, outcome, test_case)
  File "/arrow/dev/archery/archery/integration/runner.py", line 239, in _produce_consume
    consumer.validate(json_path, producer_file_path)
  File "/arrow/dev/archery/archery/integration/tester_rust.py", line 64, in validate
    return self._run(arrow_path, json_path, 'VALIDATE')
  File "/arrow/dev/archery/archery/integration/tester_rust.py", line 61, in _run
    run_cmd(cmd)
  File "/arrow/dev/archery/archery/integration/util.py", line 139, in run_cmd
    output = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
  File "/opt/conda/envs/arrow/lib/python3.8/subprocess.py", line 415, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/opt/conda/envs/arrow/lib/python3.8/subprocess.py", line 493, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/opt/conda/envs/arrow/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/opt/conda/envs/arrow/lib/python3.8/subprocess.py", line 1706, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/arrow/rust/target/debug/arrow-json-integration-test'

run: pip install -e dev/archery[docker]
- name: Execute Docker Build
run: archery docker run conda-integration
run: archery docker run -e ARCHERY_INTEGRATION_WITH_RUST=1 conda-integration
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgecarleitao @andygrove @alamb you'll need to update the integration workflow in arrow-rs once we merge this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kszucs
Copy link
Member Author

kszucs commented May 4, 2021

@pitrou verified locally that archery run conda-integration works

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @kszucs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants