[CI][C++] Flatbuffers version mismatch

[kou]

Describe the bug, including details regarding any error messages, version, and platform.

verify-rc-source-cpp-macos-amd64

https://github.com/ursacomputing/crossbow/actions/runs/14345883405/job/40215436743#step:7:1290

In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/arrow/ipc/feather.cc:36:
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/arrow/ipc/metadata_internal.h:41:
/var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/generated/Message_generated.h:11:1: error: static assertion failed due to requirement '25 == 24': Non-compatible flatbuffers version included
static_assert(FLATBUFFERS_VERSION_MAJOR == 24 &&
^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/arrow/ipc/feather.cc:36:
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/arrow/ipc/metadata_internal.h:41:
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/generated/Message_generated.h:16:
/var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/generated/Schema_generated.h:11:1: error: static assertion failed due to requirement '25 == 24': Non-compatible flatbuffers version included
static_assert(FLATBUFFERS_VERSION_MAJOR == 24 &&
^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/arrow/ipc/feather.cc:36:
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/arrow/ipc/metadata_internal.h:41:
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/generated/Message_generated.h:17:
/var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/generated/SparseTensor_generated.h:11:1: error: static assertion failed due to requirement '25 == 24': Non-compatible flatbuffers version included
static_assert(FLATBUFFERS_VERSION_MAJOR == 24 &&
^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/arrow/ipc/feather.cc:36:
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/arrow/ipc/metadata_internal.h:41:
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/generated/Message_generated.h:17:
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/generated/SparseTensor_generated.h:16:
/var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/generated/Tensor_generated.h:11:1: error: static assertion failed due to requirement '25 == 24': Non-compatible flatbuffers version included
static_assert(FLATBUFFERS_VERSION_MAJOR == 24 &&
^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/arrow/ipc/feather.cc:51:
/var/folders/k3/c71kbslj38s1vm3tnwmqyd980000gn/T/arrow-20.0.0.XXXXX.H0J4fcpm/apache-arrow-20.0.0/cpp/src/generated/feather_generated.h:11:1: error: static assertion failed due to requirement '25 == 24': Non-compatible flatbuffers version included
static_assert(FLATBUFFERS_VERSION_MAJOR == 24 &&
^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 errors generated.
make[2]: *** [src/arrow/CMakeFiles/arrow_ipc.dir/ipc/feather.cc.o] Error 1

Component(s)

C++

[WillAyd]

I will take a look - seems related to #45694

[WillAyd]

Is this by chance a new job that is running? From what I can tell, Homebrew uses flatbuffers version 25.2.10:

https://formulae.brew.sh/formula/flatbuffers#default

The Arrow codebase static asserts that only a particular version of flatbuffers gets used, and it bundles its own copy.

So maybe we should just remove flatbuffers from the Brewfile, although that looks to have been in place since 2019. I'm not sure why that would start failing recently

[kou]

Hmm. I couldn't reproduce this with local Mac mini...

[WillAyd]

Is your local build picking up the vendored copy of flatbuffers or the system installed one? I am assuming there is something in CI that is inadvertently pulling from the system rather than locally

[kou]

Issue resolved by pull request 46105
#46105