Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][C++] Fix identifier ... preceded by whitespace warnings #45605

Closed
jonkeane opened this issue Feb 23, 2025 · 5 comments
Closed

[R][C++] Fix identifier ... preceded by whitespace warnings #45605

jonkeane opened this issue Feb 23, 2025 · 5 comments
Assignees
@jonkeane
Labels
Component: C++ Type: enhancement
Milestone
20.0.0

Comments

@jonkeane
Copy link
Member

Describe the enhancement requested

On r-devel-linux-x86_64-fedora-clang we are getting some compiler warnings. The first two are in cpp11, so I think we can ignore (there's already an upstream issue r-lib/cpp11#447). But the rest are in our code and we should probably address them before submitting.

checking whether package ‘arrow’ can be installed ... [91m/56m] WARNING
Found the following significant warnings:
  /data/gannet/ripley/R/test-clang/cpp11/include/cpp11/R.hpp:52:31: warning: identifier '_xl' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  /data/gannet/ripley/R/test-clang/cpp11/include/cpp11/named_arg.hpp:42:29: warning: identifier '_nm' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-18.1.0/include/arrow/vendored/datetime/date.h:966:34: warning: identifier '_d' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-18.1.0/include/arrow/vendored/datetime/date.h:967:34: warning: identifier '_y' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-18.1.0/include/arrow/vendored/datetime/date.h:1975:13: warning: identifier '_d' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-18.1.0/include/arrow/vendored/datetime/date.h:1983:13: warning: identifier '_y' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  filesystem.cpp:261:37: warning: identifier '_nm' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
See the [install log](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/arrow-00install.html) for details.

Component(s)

C++
@jonkeane jonkeane self-assigned this Feb 23, 2025
@github-actions github-actions bot mentioned this issue Feb 23, 2025
Merged
@jonkeane jonkeane mentioned this issue Feb 23, 2025
Open
38 tasks
@kou kou changed the title [R] [C++] Fix identifier ... preceded by whitespace warnings [R][C++] Fix identifier ... preceded by whitespace warnings Feb 24, 2025
@kou
Copy link
Member

kou commented Feb 24, 2025 

  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-18.1.0/include/arrow/vendored/datetime/date.h:966:34: warning: identifier '_d' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-18.1.0/include/arrow/vendored/datetime/date.h:967:34: warning: identifier '_y' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-18.1.0/include/arrow/vendored/datetime/date.h:1975:13: warning: identifier '_d' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  /data/gannet/ripley/R/packages/tests-clang/arrow/libarrow/arrow-18.1.0/include/arrow/vendored/datetime/date.h:1983:13: warning: identifier '_y' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]

https://github.com/apache/arrow/tree/main/cpp/src/arrow/vendored/datetime is a vendored product. Could you report this to upstream https://github.com/HowardHinnant/date ?

@jonkeane
Copy link
Member Author

https://github.com/apache/arrow/tree/main/cpp/src/arrow/vendored/datetime is a vendored product. Could you report this to upstream https://github.com/HowardHinnant/date ?

Yes, I will do that as well

amoeba pushed a commit that referenced this issue Feb 24, 2025
@jonkeane
GH-45605: [R][C++] Fix identifier ... preceded by whitespace warnings (…
a01a812 
…#45606)

### Rationale for this change

Fix warnings, pass on CRAN

### What changes are included in this PR?

Removing some whitespace

### Are these changes tested?

Yes

### Are there any user-facing changes?

No, other than being releasable on CRAN

* GitHub Issue: #45605

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
@amoeba amoeba added this to the 20.0.0 milestone Feb 24, 2025
@amoeba
Copy link
Member

amoeba commented Feb 24, 2025

Issue resolved by pull request 45606
#45606

@amoeba amoeba closed this as completed Feb 24, 2025
amoeba pushed a commit that referenced this issue Feb 24, 2025
@jonkeane @amoeba
GH-45605: [R][C++] Fix identifier ... preceded by whitespace warnings (…
c47a022 
…#45606)

### Rationale for this change

Fix warnings, pass on CRAN

### What changes are included in this PR?

Removing some whitespace

### Are these changes tested?

Yes

### Are there any user-facing changes?

No, other than being releasable on CRAN

* GitHub Issue: #45605

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
kou pushed a commit to kou/arrow that referenced this issue Feb 25, 2025
@jonkeane @kou
apacheGH-45605: [R][C++] Fix identifier ... preceded by whitespace wa…
8495c8a 
…rnings (apache#45606)

### Rationale for this change

Fix warnings, pass on CRAN

### What changes are included in this PR?

Removing some whitespace

### Are these changes tested?

Yes

### Are there any user-facing changes?

No, other than being releasable on CRAN

* GitHub Issue: apache#45605

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
arashandishgar pushed a commit to arashandishgar/arrow that referenced this issue Feb 25, 2025
@jonkeane @arashandishgar
apacheGH-45605: [R][C++] Fix identifier ... preceded by whitespace wa…
57e37b2 
…rnings (apache#45606)

### Rationale for this change

Fix warnings, pass on CRAN

### What changes are included in this PR?

Removing some whitespace

### Are these changes tested?

Yes

### Are there any user-facing changes?

No, other than being releasable on CRAN

* GitHub Issue: apache#45605

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Bryce Mecum <[email protected]>
@jonkeane
Copy link
Member Author

jonkeane commented Mar 2, 2025

https://github.com/apache/arrow/tree/main/cpp/src/arrow/vendored/datetime is a vendored product. Could you report this to upstream https://github.com/HowardHinnant/date ?

Done! Sorry this took me a little bit, but here is the issue upstream HowardHinnant/date#868 and I submitted a PR to do the same.

@kou
Copy link
Member

kou commented Mar 3, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonkeane jonkeane

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
3 participants
@amoeba @kou @jonkeane