ARROW-5051: [GLib][Gandiva] Don't return temporary memory

Author: Kouhei Sutou <[email protected]> Closes #4071 from kou/glib-gandiva-fix-string-literal-node-value and squashes the following commits: 4a1811b <Kouhei Sutou> Don't return temporary memory
apache · Mar 31, 2019 · 57de5c3 · 57de5c3
1 parent cab411a
commit 57de5c3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/c_glib/gandiva-glib/node.cpp b/c_glib/gandiva-glib/node.cpp
@@ -28,7 +28,7 @@
 #include <gandiva-glib/node.hpp>
 
 template <typename Type>
-Type
+const Type &
 ggandiva_literal_node_get(GGandivaLiteralNode *node)
 {
   auto gandiva_literal_node =
@@ -1178,7 +1178,7 @@ ggandiva_string_literal_node_new(const gchar *value)
 const gchar *
 ggandiva_string_literal_node_get_value(GGandivaStringLiteralNode *node)
 {
-  auto value = ggandiva_literal_node_get<std::string>(GGANDIVA_LITERAL_NODE(node));
+  auto &value = ggandiva_literal_node_get<std::string>(GGANDIVA_LITERAL_NODE(node));
   return value.c_str();
 }