ARROW-8797: Add golden files to support ipc between different endians #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @wesm |
4 tasks
Member
|
Nit: do we want maybe to put these files in directories like
? Is there a script somewhere for generating these files? I think I have asked this in the past and I'm still not sure the answer |
Member
Author
|
Should I put a set of scripts into |
Member
|
Probably the script should be a part of apache/arrow and be used to generate a set of golden files at a point in time for a particular build, maybe it could be a part of the |
Member
Author
|
I see. I will add a bash script to apache/arrow#7507 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add golden files for big and little endians for apache/arrow#7507 based on @wesm 's suggestion.