-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataFusion Python docs #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How about using apache/arrow-datafusion-python and See also:
|
Thanks @kou. I did not realize this was an option. I will use this approach instead of creating PRs here 🚀 |
@kou I am not sure how we use GitHub Actions here to only publish the docs after the release is voted on. We would not want to push the docs on every change to master since the docs are for the released version. I guess this is a different use case compared to arrow cookbook. Are you OK with us continuing with the manual process of creating PRs here for each release? |
You could use git tags.
I.e. the workflow should run only when there is a push to tag like "v0.8.0"
…On Thu, Dec 1, 2022, 18:05 Andy Grove ***@***.***> wrote:
@kou <https://github.com/kou> I am not sure how we use GitHub Actions
here to only publish the docs after the release is voted on. We would not
want to push the docs on every change to master since the docs are for the
released version. I guess this is a different use case compared to arrow
cookbook. Are you OK with us continuing with the manual process of creating
PRs here for each release?
—
Reply to this email directly, view it on GitHub
<#279 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYUQUSA7QJQYNJBOXKIGDWLDEFJANCNFSM6AAAAAASOXRBQY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
apache/arrow-datafusion-python uses on:
push:
branches-ignore:
- '**'
tags-ignore:
- '*-rc*'
jobs:
... If you want, I can open a pull request to apache/arrow-datafusion-python. (@martin-g may be able to implement it too. :-)
Sure if you like this approach. |
Sure! Just let me know! :-) |
Let me try it! |
One can use also https://arrow.staged.apache.org/datafusion-python/ to see the docs for current Thank you for your help, @kou ! |
No description provided.