Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataFusion Python docs #279

Closed
wants to merge 1 commit into from

Conversation

andygrove
Copy link
Member

No description provided.

Copy link
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kou
Copy link
Member

kou commented Nov 29, 2022

How about using apache/arrow-datafusion-python and .asf.yaml instead of pushing this to apache/arrow-site like apache/arrow-cookbook and https://arrow.apache.org/cookbook/ ?
If we this approach, we don't need #278 .

See also:

@andygrove
Copy link
Member Author

Thanks @kou. I did not realize this was an option. I will use this approach instead of creating PRs here 🚀

@andygrove
Copy link
Member Author

@kou I am not sure how we use GitHub Actions here to only publish the docs after the release is voted on. We would not want to push the docs on every change to master since the docs are for the released version. I guess this is a different use case compared to arrow cookbook. Are you OK with us continuing with the manual process of creating PRs here for each release?

@andygrove andygrove reopened this Dec 1, 2022
@martin-g
Copy link
Member

martin-g commented Dec 1, 2022 via email

@kou
Copy link
Member

kou commented Dec 1, 2022

@kou I am not sure how we use GitHub Actions here to only publish the docs after the release is voted on.

apache/arrow-datafusion-python uses X.Y.Z-rcN tag for RC and uses X.Y.Z tag for approved release, right?
Then how about using the following configuration to update the asf-site branch?

on:
  push:
    branches-ignore:
      - '**'
    tags-ignore:
      - '*-rc*'

jobs:
  ...

If you want, I can open a pull request to apache/arrow-datafusion-python. (@martin-g may be able to implement it too. :-)

Are you OK with us continuing with the manual process of creating PRs here for each release?

Sure if you like this approach.

@martin-g
Copy link
Member

martin-g commented Dec 1, 2022

@martin-g may be able to implement it too

Sure! Just let me know! :-)

@andygrove
Copy link
Member Author

Thanks @martin-g and @kou ... I will take all the help I can get with this. @martin-g do you want to open a PR and perhaps @kou can review? Thanks again for the help with this.

@martin-g
Copy link
Member

martin-g commented Dec 5, 2022

Let me try it!

@kou kou closed this Dec 7, 2022
@martin-g
Copy link
Member

martin-g commented Dec 8, 2022

One can use also https://arrow.staged.apache.org/datafusion-python/ to see the docs for current master branch that will be released with the next version.

Thank you for your help, @kou !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants