Skip to content

Avoid a clone when creating FixedSizeBinaryArray from ArrayData #9186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 4 commits into from
Jan 21, 2026
Merged

Avoid a clone when creating FixedSizeBinaryArray from ArrayData #9186

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c925a6c
Avoid a clone when creating `FixedSizeBinaryArray` from ArrayData
alamb Jan 15, 2026
b6a7726
Merge branch 'main' into alamb/fix_sized_binary
alamb Jan 18, 2026
d61e4ca
Merge branch 'main' into alamb/fix_sized_binary
alamb Jan 18, 2026
fbf5d05
Merge branch 'main' into alamb/fix_sized_binary
alamb Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions arrow-array/src/array/fixed_size_binary_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,24 +497,25 @@ impl FixedSizeBinaryArray {

impl From<ArrayData> for FixedSizeBinaryArray {
fn from(data: ArrayData) -> Self {
let (data_type, len, nulls, offset, buffers, _child_data) = data.into_parts();

assert_eq!(
data.buffers().len(),
buffers.len(),
1,
"FixedSizeBinaryArray data should contain 1 buffer only (values)"
);
let value_length = match data.data_type() {
DataType::FixedSizeBinary(len) => *len,
let value_length = match data_type {
DataType::FixedSizeBinary(len) => len,
_ => panic!("Expected data type to be FixedSizeBinary"),
};

let size = value_length as usize;
let value_data =
data.buffers()[0].slice_with_length(data.offset() * size, data.len() * size);
let value_data = buffers[0].slice_with_length(offset * size, len * size);

Self {
data_type: data.data_type().clone(),
nulls: data.nulls().cloned(),
len: data.len(),
data_type,
nulls,
Copy link
Contributor Author

@alamb alamb Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this saves a clone of NullBuffer and a drop of DataType

I don't expect this to make much of a performance difference but it will help and I want all the From<ArrayData> impls to be consistent

len,
value_data,
value_length,
}
Expand Down
Loading