Skip to content

Minor: try and avoid an allocation creating GenericByteViewArray from ArrayData #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Jan 14, 2026
Merged

Minor: try and avoid an allocation creating GenericByteViewArray from ArrayData #9156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
772a1a7
Minor: try and avoid an allocation
alamb Jan 13, 2026
707bf41
Less verbose
alamb Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions arrow-array/src/array/byte_view_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,14 +988,16 @@ impl<'a, T: ByteViewType + ?Sized> IntoIterator for &'a GenericByteViewArray<T>

impl<T: ByteViewType + ?Sized> From<ArrayData> for GenericByteViewArray<T> {
fn from(data: ArrayData) -> Self {
let (_data_type, len, nulls, offset, mut buffers, _child_data) = data.into_parts();
let views = buffers.remove(0); // need to maintain order of remaining buffers
Copy link
Contributor Author

@alamb alamb Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is that remove(0) copies all the buffers and then Arc::from allocates/copies it again. Using Arc::from_iter builds the results directly

let buffers = Arc::from(buffers);
let views = ScalarBuffer::new(views, offset, len);
let (_data_type, len, nulls, offset, buffers, _child_data) = data.into_parts();

let mut buffers = buffers.into_iter();
// first buffer is views, remaining are data buffers
let views = ScalarBuffer::new(buffers.next().unwrap(), offset, len);

Self {
data_type: T::DATA_TYPE,
views,
buffers,
buffers: Arc::from_iter(buffers),
nulls,
phantom: Default::default(),
}
Expand Down
Loading