Skip to content

chore: switch test from bincode to maintained postcard crate (RUSTSEC-2025-0141 )#9104

Merged
alamb merged 1 commit intoapache:mainfrom
alamb:alamb/remove_bincode
Jan 8, 2026
Merged

chore: switch test from bincode to maintained postcard crate (RUSTSEC-2025-0141 )#9104
alamb merged 1 commit intoapache:mainfrom
alamb:alamb/remove_bincode

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 6, 2026

Which issue does this PR close?

Rationale for this change

https://crates.io/crates/bincode is unmaintained

Screenshot 2026-01-06 at 5 57 13 PM

There also appears to be some sort of drama related to the maintainer

While we only use this code in tests, it would be nice to avoid issues sooner rather than later

What changes are included in this PR?

Change to use postcard

Are these changes tested?

by ci

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 6, 2026
@alamb alamb changed the title Chore: switch serialization test to maintained postcard crate chore: switch serialization test to maintained postcard crate Jan 6, 2026
@alamb alamb changed the title chore: switch serialization test to maintained postcard crate chore: switch serialization away from bincode to to maintained postcard crate Jan 7, 2026
@alamb alamb marked this pull request as ready for review January 7, 2026 20:53
@alamb alamb changed the title chore: switch serialization away from bincode to to maintained postcard crate chore: switch serialization away from bincode to to maintained postcard crate (RUSTSEC-2025-0141 ) Jan 7, 2026
@alamb alamb changed the title chore: switch serialization away from bincode to to maintained postcard crate (RUSTSEC-2025-0141 ) chore: switch test from bincode to maintained postcard crate (RUSTSEC-2025-0141 ) Jan 7, 2026
@alamb alamb merged commit 964daec into apache:main Jan 8, 2026
31 of 32 checks passed
Dandandan pushed a commit to Dandandan/arrow-rs that referenced this pull request Jan 15, 2026
…TSEC-2025-0141 ) (apache#9104)

# Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax.
-->

- Closes apache#9009
- Also addresses https://rustsec.org/advisories/RUSTSEC-2025-0141 --
this is only used for testing but still

# Rationale for this change

https://crates.io/crates/bincode is unmaintained

<img width="833" height="657" alt="Screenshot 2026-01-06 at 5 57 13 PM"
src="https://github.com/user-attachments/assets/9e18a6e5-eb45-4470-94b7-e17b89ad558e"
/>

There also appears to be some sort of drama related to the maintainer

While we only use this code in tests, it would be nice to avoid issues
sooner rather than later

# What changes are included in this PR?

Change to use postcard

# Are these changes tested?
by ci

# Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.

If there are any breaking changes to public APIs, please call them out.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants