Skip to content

Conversation

@liamzwbao
Copy link
Contributor

@liamzwbao liamzwbao commented Jan 5, 2026

Which issue does this PR close?

Rationale for this change

To support Lists/Array in variant_get, it's better to move ArrayVariantToArrowRowBuilder from shred_variant to variant_to_arrow and be shared with variant_get. In the meantime, some code movement in variant_to_arrow would help to get a better overview of the overall implementation

What changes are included in this PR?

This PR can be reviewed commit by commit:

  • Move VariantToArrowRowBuilder and related impl to the top of variant_to_arrow
  • Push the FixedSizeList check from make_variant_to_shredded_variant_arrow_row_builder down to ArrayVariantToArrowRowBuilder
  • Move ArrayVariantToArrowRowBuilder to variant_to_arrow

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet-variant parquet-variant* crates label Jan 5, 2026
@liamzwbao liamzwbao marked this pull request as ready for review January 5, 2026 00:31
@liamzwbao
Copy link
Contributor Author

Hi @alamb @scovich, here is the PR with code movement only. Once it's merged, #9049 would be easier to review

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, LGTM

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liamzwbao and @klion26

@alamb alamb merged commit a9d6e92 into apache:main Jan 5, 2026
19 checks passed
@scovich
Copy link
Contributor

scovich commented Jan 7, 2026

Sorry I missed the notification, but this looks great, thanks!

@liamzwbao liamzwbao deleted the issue-8082-refactor-variant-to-arrow branch January 8, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet-variant parquet-variant* crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants