Skip to content

bench: added to row_format benchmark conversion of 53 non-nested columns #9081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Jan 10, 2026
Merged

bench: added to row_format benchmark conversion of 53 non-nested columns #9081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6e5b7c
bench: added to row_format benchmark conversion of 50 non-nested columns
rluvaton Dec 31, 2025
3c5bf63
Explicitly list number of columns
alamb Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 104 additions & 3 deletions arrow/benches/row_format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@ use arrow::array::ArrayRef;
use arrow::datatypes::{Int64Type, UInt64Type};
use arrow::row::{RowConverter, SortField};
use arrow::util::bench_util::{
create_boolean_array, create_dict_from_values, create_primitive_array,
create_string_array_with_len, create_string_dict_array, create_string_view_array_with_len,
create_boolean_array, create_boolean_array_with_seed, create_dict_from_values,
create_f64_array_with_seed, create_primitive_array, create_primitive_array_with_seed,
create_string_array_with_len, create_string_array_with_len_range_and_prefix_and_seed,
create_string_dict_array, create_string_view_array_with_len,
create_string_view_array_with_max_len,
};
use arrow::util::data_gen::create_random_array;
use arrow_array::Array;
use arrow_array::types::Int32Type;
use arrow_array::types::{Int8Type, Int32Type};
use arrow_schema::{DataType, Field};
use criterion::Criterion;
use std::{hint, sync::Arc};
Expand Down Expand Up @@ -85,6 +87,102 @@ fn bench_iter(c: &mut Criterion) {
});
}

/// A single benchmark with a medium number of columns (around 50) without nested columns for real-world use cases
/// This also makes sure there is a large gap between each value in the column and how it is laid out in the row format.
/// and it is on the edge of not fitting in L3 on some machines
fn run_benchmark_on_medium_amount_and_types_of_columns_without_nesting(
batch_size: usize,
c: &mut Criterion,
) {
let mut seed = 0;

let mut cols: Vec<ArrayRef> = vec![];

for nulls in [0.0, 0.1, 0.2, 0.5] {
seed += 1;
cols.push(Arc::new(create_primitive_array_with_seed::<Int8Type>(
batch_size, nulls, seed,
)) as ArrayRef);
}

for nulls in [0.0, 0.1, 0.2, 0.5] {
seed += 1;
cols.push(Arc::new(create_primitive_array_with_seed::<Int32Type>(
batch_size, nulls, seed,
)) as ArrayRef);
}

for nulls in [0.0, 0.1, 0.2, 0.5] {
seed += 1;
cols.push(Arc::new(create_primitive_array_with_seed::<Int64Type>(
batch_size, nulls, seed,
)) as ArrayRef);
}

for _ in 0..10 {
seed += 1;
cols.push(Arc::new(create_primitive_array_with_seed::<Int64Type>(
batch_size, 0.0, seed,
)) as ArrayRef);
}

for nulls in [0.0, 0.1, 0.2, 0.5] {
seed += 1;
cols.push(Arc::new(
create_string_array_with_len_range_and_prefix_and_seed::<i32>(
batch_size, nulls, 0, 50, "", seed,
),
));
}

for _ in 0..3 {
Copy link
Contributor

@alamb alamb Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about also adding a StringView column too (in addition to string)

seed += 1;
cols.push(Arc::new(
create_string_array_with_len_range_and_prefix_and_seed::<i32>(
batch_size, 0.0, 0, 10, "", seed,
),
));
}
for _ in 0..3 {
seed += 1;
cols.push(Arc::new(
create_string_array_with_len_range_and_prefix_and_seed::<i32>(
batch_size, 0.0, 10, 20, "", seed,
),
));
}
for _ in 0..3 {
seed += 1;
cols.push(Arc::new(
create_string_array_with_len_range_and_prefix_and_seed::<i32>(
batch_size, 0.0, 20, 30, "", seed,
),
));
}

for nulls in [0.0, 0.1, 0.2, 0.5] {
seed += 1;
cols.push(Arc::new(create_boolean_array_with_seed(
batch_size, nulls, 0.5, seed,
)));
}

for _ in 0..10 {
seed += 1;
cols.push(Arc::new(create_primitive_array_with_seed::<Int64Type>(
batch_size, 0.0, seed,
)) as ArrayRef);
}

for nulls in [0.0, 0.1, 0.2, 0.5] {
seed += 1;
cols.push(Arc::new(create_f64_array_with_seed(batch_size, nulls, seed)) as ArrayRef);
}

assert_eq!(cols.len(), 53);
do_bench(c, format!("{batch_size} 53 columns").as_str(), cols);
}

fn row_bench(c: &mut Criterion) {
let cols = vec![Arc::new(create_primitive_array::<UInt64Type>(4096, 0.)) as ArrayRef];
do_bench(c, "4096 u64(0)", cols);
Expand Down Expand Up @@ -279,6 +377,9 @@ fn row_bench(c: &mut Criterion) {
];
do_bench(c, "4096 large_list(0) sliced to 10 of u64(0)", cols);

run_benchmark_on_medium_amount_and_types_of_columns_without_nesting(4096, c);
run_benchmark_on_medium_amount_and_types_of_columns_without_nesting(8192, c);

bench_iter(c);
}

Expand Down
38 changes: 38 additions & 0 deletions arrow/src/util/bench_util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,29 @@ where
.collect()
}

/// Creates a random array of a given size and null density based on the provided seed
pub fn create_boolean_array_with_seed(
size: usize,
null_density: f32,
true_density: f32,
seed: u64,
) -> BooleanArray
where
StandardUniform: Distribution<bool>,
{
let mut rng = StdRng::seed_from_u64(seed);
(0..size)
.map(|_| {
if rng.random::<f32>() < null_density {
None
} else {
let value = rng.random::<f32>() < true_density;
Some(value)
}
})
.collect()
}

/// Creates a random (but fixed-seeded) string array of a given size and null density.
///
/// Strings have a random length
Expand Down Expand Up @@ -734,3 +757,18 @@ pub fn create_f64_array(size: usize, nan_density: f32) -> Float64Array {
})
.collect()
}

/// Creates a random f64 array of a given size and nan-value density based on a given seed
pub fn create_f64_array_with_seed(size: usize, nan_density: f32, seed: u64) -> Float64Array {
let mut rng = StdRng::seed_from_u64(seed);

(0..size)
.map(|_| {
if rng.random::<f32>() < nan_density {
Some(f64::NAN)
} else {
Some(rng.random())
}
})
.collect()
}
Loading