bench: added to row_format benchmark conversion of 53 non-nested columns #9081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 7, 2026
| )); | ||
| } | ||
|
|
||
| for _ in 0..3 { |
Contributor
There was a problem hiding this comment.
how about also adding a StringView column too (in addition to string)
arrow/benches/row_format.rs
Outdated
| cols.push(Arc::new(create_f64_array_with_seed(batch_size, nulls, seed)) as ArrayRef); | ||
| } | ||
|
|
||
| do_bench(c, format!("{batch_size} lot of columns").as_str(), cols); |
Contributor
There was a problem hiding this comment.
Could you please make the description more precise (specificially, "how many" columns) -- maybe with an assert too to make sure the benchmark stays in sync
assert_eq!(cols.len(), 50)
Contributor
There was a problem hiding this comment.
Since I am trying to clear the backlog, I took the liberty of making this change and pushing to this PR 3c5bf63
alamb
changed the title
Dandandan
pushed a commit
to Dandandan/arrow-rs
that referenced
this pull request
Jan 15, 2026
…mns (apache#9081) # Which issue does this PR close? N/A # Rationale for this change I noticed that converting around 50 columns the conversion become very slow, so adding a benchmark as I'm optimizing those parts # What changes are included in this PR? added new benchmark for `row_format` that convert 50 columns arrays # Are these changes tested? N/A # Are there any user-facing changes? Nope --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
I noticed that converting around 50 columns the conversion become very slow, so adding a benchmark as I'm optimizing those parts
What changes are included in this PR?
added new benchmark for
row_formatthat convert 50 columns arraysAre these changes tested?
N/A
Are there any user-facing changes?
Nope