perf: improve performance of encoding GenericByteArray by 8%#9054
Merged
alamb merged 3 commits intoapache:mainfrom Dec 30, 2025
Merged
Conversation
rluvaton
changed the title
GenericByteArray by 15%-20%GenericByteArray by 8%
Member
Author
|
Waiting for to run row format benchmark |
Contributor
|
run benchmark row_format |
|
🤖 |
alamb
reviewed
Dec 29, 2025
arrow-row/src/variable.rs
Outdated
| .zip(null_buffer.iter()) | ||
| .map(|(start_end, is_valid)| { | ||
| if is_valid { | ||
| Some(&bytes[start_end[0].as_usize()..start_end[1].as_usize()]) |
Contributor
There was a problem hiding this comment.
it might also be worth trying bytes.get_unchecked(...) here to skip the bounds checks if it helps
The input array has been validated so it is safe to assume the offsets are in range
|
🤖: Benchmark completed Details
|
… chance for skipping the encode null for non nullable
Member
Author
|
run benchmark row_format |
|
🤖 |
|
🤖: Benchmark completed Details
|
Contributor
|
Looks like an improvement to me when converting strings (though the benchmarks are noisy) |
Contributor
|
Thanks @rluvaton |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Make row conversion faster
What changes are included in this PR?
created "manual" iterator over the byte array and offsets with optimizations for no nulls
Are these changes tested?
Existing tests
Are there any user-facing changes?
No