feat: add new try_append_value_n() function to GenericByteViewBuilder
#9040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyang24
force-pushed
the
append_n
branch
2 times, most recently
from
fb24646 to
54fd242
Compare
Jefffrey
reviewed
Dec 24, 2025
lyang24
changed the title
Jefffrey
approved these changes
Dec 24, 2025
alamb
reviewed
Dec 24, 2025
lyang24
force-pushed
the
append_n
branch
2 times, most recently
from
124b71b to
f43fd87
Compare
Signed-off-by: lyang24 <[email protected]>
Contributor
|
I don't think the failure in the integration test is related |
Jefffrey
changed the title
try_append_value_n() function to GenericByteViewBuilder
Contributor
github-merge-queue bot
pushed a commit
to apache/datafusion
that referenced
this pull request
Jan 16, 2026
…s methods (#19797) These PRs are available to us now as part of upgrade to arrow-s 57.2.0 (#19355): - apache/arrow-rs#8993 - apache/arrow-rs#9040 Make use of them in some refactorings here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
append_nto bytes view builder API #9034.Rationale for this change
remove boiler plate code upstream, ensure only hash once instead n times.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?