Skip to content

Fix clippy #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Nov 1, 2021
Merged

Fix clippy #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion parquet/src/util/hash_util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ const MURMUR_R: i32 = 47;

/// Rust implementation of MurmurHash2, 64-bit version for 64-bit platforms
fn murmur_hash2_64a(data_bytes: &[u8], seed: u64) -> u64 {
Copy link
Member

@jimexist jimexist Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would call for using murmur hash 3 if possible

Copy link
Contributor Author

@alamb alamb Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimexist shall I file a ticket? I don't really know why the parquet implementation is using its own hash function rather than, say, aHash or some other standard hashing library in rust

use std::convert::TryInto;
let len = data_bytes.len();
let len_64 = (len / 8) * 8;

Expand Down