[Variant] Unify the CastOptions usage in parquet-variant-compute#8984
Merged
alamb merged 1 commit intoapache:mainfrom Dec 30, 2025
Merged
[Variant] Unify the CastOptions usage in parquet-variant-compute#8984alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
07a7645 to
5c530ce
Compare
5c530ce to
7abc92b
Compare
Member
Author
|
@alamb this pr unified the usage of |
Contributor
|
Thanks again @klion26 |
Member
Author
|
@alamb thanks for the review and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Unify the
CastOptionsusage inparquet-variant-computeCurrently, there is only
arrow::compute::CastOptionsinparquet-variant-computenow, the existingparquet-variant-compute/CastOptionshas replaced by thearrow::compute::CastOptionswith the equal behaviorAre these changes tested?
The existing tests covered the logic
Are there any user-facing changes?
This will break some public API in
parquet-variant-compute, but this crate isexperimentnow, so maybe we don't need to wait for a major release.