Skip to content

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Oct 30, 2021

Which issue does this PR close?

Depends on #591

Rationale for this change

to simplify code, reduce duplication

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021

Codecov Report

Merging #883 (7513eca) into master (f4fdc9c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
+ Coverage   82.29%   82.31%   +0.02%     
==========================================
  Files         168      168              
  Lines       48122    48031      -91     
==========================================
- Hits        39600    39535      -65     
+ Misses       8522     8496      -26     
Impacted Files Coverage Δ
arrow/src/compute/kernels/cast.rs 94.81% <100.00%> (+0.34%) ⬆️
parquet/src/encodings/encoding.rs 93.52% <0.00%> (-0.20%) ⬇️
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.22%) ⬆️
arrow/src/array/transform/mod.rs 85.47% <0.00%> (+0.27%) ⬆️
arrow/src/datatypes/datatype.rs 65.36% <0.00%> (+0.43%) ⬆️
arrow/src/array/data.rs 74.93% <0.00%> (+0.81%) ⬆️
arrow/src/array/array.rs 85.71% <0.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ffa24...7513eca. Read the comment docs.

@jimexist jimexist merged commit 06f730e into apache:master Nov 1, 2021
@alamb
Copy link
Contributor

alamb commented Nov 4, 2021

not backporting as it needs newer rust edition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants