Skip to content

Conversation

@DCjanus
Copy link

@DCjanus DCjanus commented Oct 11, 2025

• # Which issue does this PR close?

Rationale for this change

cargo deny flags the unmaintained paste crate, so advisory checks fail until we remove it. Switching to the maintained drop-in replacement keeps the dependency tree healthy and restores the advisory gate.

What changes are included in this PR?

  • Replace all paste dependencies with pastey across Arrow Flight, Parquet, and Parquet Variant crates.
  • Update source files to import pastey::paste instead of paste::paste.
  • Refresh Cargo.lock so it pulls in pastey.

Are these changes tested?

  • cargo check -p parquet
  • cargo deny check advisories

Are there any user-facing changes?

No user-facing changes or API adjustments.

@github-actions github-actions bot added parquet Changes to the parquet crate arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet-variant parquet-variant* crates labels Oct 11, 2025
@alamb
Copy link
Contributor

alamb commented Oct 11, 2025

I feel like there might actually be more risk with a new crate than sticking with the old crate -- even if it is 'unmaintained' if it doesn't need maintenance then what is the harm

If we really want to remove the dependency on paste, I think it would be better to vendor it into arrow (aka copy the relevant parts we need)

@alamb
Copy link
Contributor

alamb commented Oct 11, 2025

Thank you for this contribution @DCjanus

@DCjanus DCjanus marked this pull request as draft October 13, 2025 06:37
@DCjanus
Copy link
Author

DCjanus commented Oct 13, 2025

I feel like there might actually be more risk with a new crate than sticking with the old crate -- even if it is 'unmaintained' if it doesn't need maintenance then what is the harm

I think I'm convinced, perhaps we can keep things as they are for now, until one day we need to change it

@DCjanus DCjanus closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-variant parquet-variant* crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parquet relies on unmaintained dependency paste

2 participants