Propagate errors instead of panics: Replace usages of new with try_new for Array types
#8397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
alamb
changed the title
new with try_new for Array typesnew with try_new for Array types
Contributor
|
(I also double checked that this didn't change any APIs externally, just propagated errors correctly internally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #7806
Rationale for this change
Some methods in
arrowusenew()of array types which internally usetry_new()and unwraps the result; this can lead to panics instead of propagating errors to downstream users. For example, this DataFusion issue: apache/datafusion#12598What changes are included in this PR?
Replace usages of
new()withtry_new()where appropriate (the function they are used inside already return aResult.Are these changes tested?
Covered by existing tests.
Are there any user-facing changes?
No.