Skip to content

Conversation

@Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Sep 14, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

If there are user-facing changes then we may require documentation to be updated before approving the PR.

If there are any breaking changes to public APIs, please call them out.

@github-actions github-actions bot added the parquet-variant parquet-variant* crates label Sep 14, 2025
@Weijun-H Weijun-H force-pushed the 8329-type-access-for-boolean branch from 31de181 to f873465 Compare September 14, 2025 08:40
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @Weijun-H

@Weijun-H Weijun-H force-pushed the 8329-type-access-for-boolean branch from f873465 to 3fa4c4d Compare September 14, 2025 13:09
@Weijun-H Weijun-H changed the title feat: Support typed_access for Boolean [Variant] feat: Support typed_access for Boolean Sep 14, 2025
]);

let struct_array = StructArrayBuilder::new()
.with_field("metadata", Arc::new(metadata))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that Once this PR is merged, it should be rewritten.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- I will resolve the conflict

@mbrobbel mbrobbel merged commit 20ccf5f into apache:main Sep 15, 2025
13 checks passed
@alamb
Copy link
Contributor

alamb commented Sep 15, 2025

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet-variant parquet-variant* crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Variant] [Shredding] Support typed_access for Boolean

4 participants