-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add into_builder method for WriterProperties #8272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@adamreeve |
adamreeve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Makes sense to me.
Looking at other into_builder methods in the arrow-rs codebase, they often seem to delegate to calling into or from. It might be nice to also provide an impl From<WriterProperties> for WriterPropertiesBuilder, so users have a choice to use that or the more explicit into_builder.
Alright. I added that as well. |
etseidl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible to me. Thanks @corwinjoy
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @corwinjoy , @adamreeve and @etseidl
I agree this looks good to me
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Which issue does this PR close?
Rationale for this change
When working with the library using encryption, we have sometimes found it necessary to modify an existing set of
WriterPropertieson a per-file basis to set specific encryption properties. More generally, others may need to use an existing set ofWriterPropertiesas a template and modify the properties. I have implemented this feature by adding aninto_buildermethod, which appears to be the standard approach in other parts of the library.Are these changes tested?
Yes,
test_writer_properties_builderhas been updated to add a round-trip test forinto_builder.Are there any user-facing changes?
Yes.
WriterPropertiesnow has a newinto_buildermethod.