Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 13, 2025

Which issue does this PR close?

We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.

Rationale for this change

We are trying to avoid adding new dependencies into the parquet crate while adding Variant support

However, eventually to use Variants with Parquet, a user will need to use code from both the parquet crate and the parquet-variant and parquet-variant-compute crates. To so I propose adding a new parquet-variant-integration-testing crate`

What changes are included in this PR?

  1. Add a new parquet-variant-integration-testing crate
  2. Move the test from [VARIANT] Initial integration tests for variant reads #8104 by @carpecodeum to this new crate
  3. Add new crate to various build process

Are these changes tested?

We typically require tests for all PRs in order to:

  1. Prevent the code from being accidentally broken by subsequent changes
  2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?

Are there any user-facing changes?

If there are user-facing changes then we may require documentation to be updated before approving the PR.

If there are any breaking changes to public APIs, please call them out.

@alamb
Copy link
Contributor Author

alamb commented Aug 13, 2025

I thought a bit about this approach, and the more I think about it, the more I am thinking it might be simpler to put this test in the parquet-variant-compute crate 🤔 I will ponder

@alamb alamb force-pushed the alamb/parquet-variant-integration-testing branch from 6e1790f to b5dc667 Compare August 13, 2025 14:38
@alamb
Copy link
Contributor Author

alamb commented Aug 13, 2025

Actually, the more I think about this, the more I think maybe we want a variant feature as part of the parquet crate. That will be much easier to use than having to use a separate crate. I'll make a PR to see what that would look like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant