-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Implement arrow-avro SchemaStore and Fingerprinting To Enable Schema Resolution #8006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
4890faa
Added arrow-avro `SchemaStore` and fingerprint support to `schema.rs`…
jecsand838 f8040c6
Update arrow-avro/src/reader/mod.rs
jecsand838 f2f34d0
Update arrow-avro/src/reader/mod.rs
jecsand838 3db9aed
Update arrow-avro/src/reader/mod.rs
jecsand838 da7b1b9
Address PR Comments
jecsand838 ed7fb49
Update arrow-avro/src/reader/mod.rs
jecsand838 8e6face
Update arrow-avro/src/reader/mod.rs
jecsand838 25c3899
Address Remaining PR Comments
jecsand838 bf55dba
Update arrow-avro/src/reader/mod.rs
jecsand838 a113399
Update arrow-avro/src/reader/mod.rs
jecsand838 5c8e045
Address Follow-up PR Comments
jecsand838 c8fce60
Update arrow-avro/src/codec.rs
jecsand838 c631218
Update arrow-avro/src/reader/mod.rs
jecsand838 d014bfb
Update arrow-avro/src/reader/mod.rs
jecsand838 7bffdb6
Update arrow-avro/src/reader/mod.rs
jecsand838 72afc79
Update arrow-avro/src/schema.rs
jecsand838 6aac06c
Address Follow-up PR Comments
jecsand838 81fae32
Update arrow-avro/src/reader/mod.rs
jecsand838 6fd3234
Update arrow-avro/src/reader/mod.rs
jecsand838 6a84a05
Update arrow-avro/src/reader/mod.rs
jecsand838 24cb8a2
Update arrow-avro/src/reader/mod.rs
jecsand838 07b55c4
Update arrow-avro/src/reader/mod.rs
jecsand838 4f734e2
Update arrow-avro/src/reader/mod.rs
jecsand838 9c828c6
Update arrow-avro/src/reader/mod.rs
jecsand838 dc56c70
Remove LRU cache feature and refactor StoreStore + AvroSchema handlin…
jecsand838 5a1b7e4
Merge branch 'main' into avro-reader-schema-store
jecsand838 fc6a5cb
Update arrow-avro/src/reader/mod.rs
jecsand838 eca7ca3
Update arrow-avro/src/reader/mod.rs
jecsand838 ef9051e
Update arrow-avro/src/reader/mod.rs
jecsand838 da0cfc2
Merge branch 'apache:main' into avro-reader-schema-store
jecsand838 c450401
Updated decoder benchmarks to include Avro single-object prefix gener…
jecsand838 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside: I guess this is a low-level avro schema instance, not the arrow schema
Schema?At least, I don't remember arrow Schema objects having a lifetime parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah --
SchemaRefis from arrow-schema, butSchemais crate-local.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could rename to disambiguate?
ArrowSchemaRefvs.[Avro]Schema?