Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jul 18, 2025

Which issue does this PR close?

Rationale for this change

I noticed in #7956 that some Clippy errors were introduced but not caught by CI.

What changes are included in this PR?

Add parquet-variant-compute to the CI for parqet-variant related PRs

Are these changes tested?

It is only tests

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of arrow-rs label Jul 18, 2025
@alamb
Copy link
Contributor Author

alamb commented Jul 18, 2025

Aha -- the CI test caught a real error (fixed in #7956 (comment))


    Checking arrow v55.2.0 (/__w/arrow-rs/arrow-rs/arrow)
    Checking parquet-variant-compute v0.1.0 (/__w/arrow-rs/arrow-rs/parquet-variant-compute)
error: this expression creates a reference which is immediately dereferenced by the compiler
  --> parquet-variant-compute/src/variant_array.rs:98:70
   |
98 |         let Some(metadata_field) = VariantArray::find_metadata_field(&inner) else {
   |                                                                      ^^^^^^ help: change this to: `inner`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `-D clippy::needless-borrow` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> parquet-variant-compute/src/variant_array.rs:109:64
    |
109 |         let Some(value_field) = VariantArray::find_value_field(&inner) else {
    |                                                                ^^^^^^ help: change this to: `inner`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: could not compile `parquet-variant-compute` (lib) due to 2 previous errors

@alamb
Copy link
Contributor Author

alamb commented Jul 18, 2025

In order to keep the CI clean, I am going to merge this without review

@alamb alamb changed the title Add missing parquet-variant-compute crate to CI jobs Add missing parquet-variant-compute crate to CI jobs Jul 18, 2025
@alamb alamb merged commit 99eb1bc into apache:main Jul 18, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of arrow-rs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant