Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Jul 11, 2025

Which issue does this PR close?

None

Rationale for this change

Currently the CI is failed:

https://github.com/apache/arrow-rs/actions/runs/16210835231/job/45770459574?pr=7897

 error: unnecessary parentheses around closure body
   --> arrow-ord/src/cmp.rs:276:43
    |
276 |                     let c = |((l, r), n)| ((l ^ r) | (l & r & n));
    |                                           ^                     ^
    |
    = note: `-D unused-parens` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_parens)]`
help: remove these parentheses
    |
276 -                     let c = |((l, r), n)| ((l ^ r) | (l & r & n));
276 +                     let c = |((l, r), n)| (l ^ r) | (l & r & n);
    |

What changes are included in this PR?

Fix CI.

Are these changes tested?

Existing test.

Are there any user-facing changes?

No

@viirya viirya requested a review from alamb July 11, 2025 05:42
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 11, 2025
@alamb
Copy link
Contributor

alamb commented Jul 11, 2025

Thank you @viirya and @mbrobbel

@alamb alamb merged commit 4c088fe into apache:main Jul 11, 2025
21 of 22 checks passed
@viirya
Copy link
Member Author

viirya commented Jul 11, 2025

Thank you @mbrobbel @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants