fix: view_types benchmark slice should follow by correct len array
#7892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
view_types benchmark slice should follow by correct len array
alamb
approved these changes
Jul 10, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @zhuqi-lucas -- I verified that on main running
cargo bench --bench view_typesPanics with this error
Benchmarking view types slice: Warming up for 3.0000 s
thread 'main' panicked at arrow-buffer/src/buffer/immutable.rs:297:9:
the offset of the new Buffer cannot exceed the existing length: slice offset=0 length=800000 selflen=128000
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p arrow-array --bench view_types`
And it does not panic with this RP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fix the bug that view types slice benchmark not using the right len after we added new benchmark.
Rationale for this change
Fix the bug that view types slice benchmark not using the right len after we added new benchmark.
What changes are included in this PR?
Fix the bug that view types slice benchmark not using the right len after we added new benchmark.
Are these changes tested?
Yes
Are there any user-facing changes?
No