benchmark: Add StringViewArray gc benchmark with not null cases #7877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 7, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thank you @zhuqi-lucas 🙏
| }); | ||
| }); | ||
|
|
||
| let array = gen_view_array_without_nulls(100_000); |
Contributor
There was a problem hiding this comment.
100_000 seems like an overly large array to be checking (though I see the other benchmarks also use that number)
Given we recommend batch sizes more ike 8k, maybe we should change the benchmark (in a follow on PR) to use 10K or 8K rows instead
Contributor
Author
There was a problem hiding this comment.
Thank you @alamb for good suggestion, i also addressed this in latest PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
See comments:
#7873 (comment)
We need to Add StringViewArray gc benchmark with not null cases before we optimizing the performance for this case.
cc @Dandandan
Rationale for this change
Add StringViewArray gc benchmark with not null cases
What changes are included in this PR?
Add StringViewArray gc benchmark with not null cases
Are these changes tested?
Yes
Are there any user-facing changes?
No