-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Split out variant code into several new sub-modules #7717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
NOTE: The code movement exposed some parts of the code that have no direct unit tests:
If we think the above represents an actual test gap, we may want to file some (good first) issues? |
|
YES ! thank you @scovich |
Sounds good to me Note that doc examples I think function as unit tests as well, so we can include them too |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank yoU @scovich
I'll fix the docs CI test and then merge this one in as it has a high potential to attract conflicts in other related PRs
Whoop, I didn't see this. Just pushed a fix for the doc tests. |
|
... or rather, just attempted to push; your fix won the race |
|
Looks like I missed another one 🤦 |
Co-authored-by: Ryan Johnson <[email protected]>
Which issue does this PR close?
Housekeeping, part of
Rationale for this change
The variant module was starting to become unwieldy.
What changes are included in this PR?
Split out metadata, object, and list to sub-modules; move
OffsetSizeto the decoder module where it arguably belongs.Result: variant.rs is "only" ~900 LoC instead of ~2kLoc.
Are there any user-facing changes?
No. Public re-exports should hide the change from users.