Include footer key metadata when writing encrypted Parquet with a plaintext footer #7600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2025
adamreeve
reviewed
Jun 4, 2025
adamreeve
approved these changes
Jun 4, 2025
Contributor
adamreeve
left a comment
adamreeve
left a comment
There was a problem hiding this comment.
Looks good to me thanks Rok
adamreeve
changed the title
alamb
approved these changes
Jun 6, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @rok and @adamreeve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7599.
Rationale for this change
Written plaintext footer file will not include
footer_signing_key_metadata, see proposed test for reproduction.Written encrypted non-plaintext footer files shouldn't include
encryption_algorithm, see proposed test for reproduction.What changes are included in this PR?
footer_signing_key_metadatais now included in plaintext footer file andencryption_algorithmis not included in the footer if footer is non-plaintext.Are there any user-facing changes?
This doesn't change user facing API.