Add FixedSizeBinary to take_kernel benchmark
#7592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrobbel
approved these changes
Jun 2, 2025
Contributor
Author
|
Thanks for the review @mbrobbel ! |
Contributor
Author
|
Since this is just a benchmark I am merging it in to make it easier for my scripts to run. Thank you @mbrobbel for your help |
CookiePieWw
added a commit
to CookiePieWw/arrow-rs
that referenced
this pull request
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PrimitiveBuilder::append_trusted_len_iter#7591Rationale for this change
I would like a benchmark that shows improvements in #7590
takewith FixedSizeBinary is the only one I know of nowWhat changes are included in this PR?
Add
fsbto the take_kernel benchmarksAre there any user-facing changes?
No, this is a benchmark