Fix bug in ParquetMetaDataReader and add test of suffix metadata reads with encryption
#7372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Apr 1, 2025
Comment on lines
+714
to
+716
| // need to slice off the footer or decryption fails | ||
| self.decode_footer_metadata(&meta.slice(0..length), &footer)?, | ||
| None, |
Member
There was a problem hiding this comment.
Does this indeed fail the added test if not changed? So it's not just adding a test it's fixing a bug?
Contributor
Author
There was a problem hiding this comment.
Yes...without this change the added test fails.
Contributor
There was a problem hiding this comment.
I verified that without this change the new test fails like this:
---- file::metadata::reader::async_tests::test_suffix_with_encryption stdout ----
thread 'file::metadata::reader::async_tests::test_suffix_with_encryption' panicked at parquet/src/file/metadata/reader.rs:1458:14:
called `Result::unwrap()` on an `Err` value: General("Provided footer key and AAD were unable to decrypt parquet footer")
etseidl
changed the title
ParquetMetaDataReader and add test of suffix metadata reads with encryption
adamreeve
approved these changes
Apr 1, 2025
alamb
approved these changes
Apr 2, 2025
Comment on lines
+714
to
+716
| // need to slice off the footer or decryption fails | ||
| self.decode_footer_metadata(&meta.slice(0..length), &footer)?, | ||
| None, |
Contributor
There was a problem hiding this comment.
I verified that without this change the new test fails like this:
---- file::metadata::reader::async_tests::test_suffix_with_encryption stdout ----
thread 'file::metadata::reader::async_tests::test_suffix_with_encryption' panicked at parquet/src/file/metadata/reader.rs:1458:14:
called `Result::unwrap()` on an `Err` value: General("Provided footer key and AAD were unable to decrypt parquet footer")
Contributor
Author
|
Thanks everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
While working on #7369 I found an issue with doing suffix reads of the metadata coupled with encryption.
What changes are included in this PR?
Slice the footer off the buffer before passing it on to the decode function, as is done several lines below.
Added a test that fails if the change around line 713 is reverted.
Are there any user-facing changes?
No