bugfix: adjust allocated_size() in GenericByteViewBuilder #7104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chen-Yuan-Lai
changed the title
mbrobbel
approved these changes
Feb 10, 2025
Member
mbrobbel
left a comment
mbrobbel
left a comment
There was a problem hiding this comment.
Perhaps we should re-consider https://github.com/apache/arrow-rs/pull/7089/files#r1945293119, because having allocated_size return both bytes and bits may cause confusion; this PR is an example.
Contributor
|
IMO allocated_size being in bits is a bug and should be fixed - #7089 (comment). Allocations can't be made at bit granularity and so the notion this method should return in bits seems odd to me |
Contributor
|
I've filed #7121 to change the allocated_size to be in bytes, going to mark this as a draft in the meantime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7099 .
Rationale for this change
As #7099 says,
allocated_size()inGenericByteViewBuilderneeds to be adjusted since allocated_size() inNullBufferBuilderreturns bits, not bytes.What changes are included in this PR?
Are there any user-facing changes?
allocated_sizeby 8.