Skip to content

Conversation

@rluvaton
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

When working on apache/datafusion#14299 I had to look through the code to understand if the end is exclusive or not

Are there any user-facing changes?

only docs

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 25, 2025
@alamb alamb added the documentation Improvements or additions to documentation label Jan 27, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 -- thank you @rluvaton 📖

/// Returns `(usize, usize)` each representing an interval where the corresponding
/// bits in the provides mask are set
///
/// the first value is the start of the range (inclusive) and the second value is the end of the range (exclusive)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

I double checked and this looks good. Thanks @rluvaton

type Item = (usize, usize);

@alamb alamb merged commit a28f4ef into apache:main Jan 27, 2025
26 checks passed
@rluvaton rluvaton deleted the add-docs branch January 27, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants