Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jul 29, 2021

Which issue does this PR close?

NA

Rationale for this change

It's that time again! Rust released 1.54 today which causes some additional clippy errors:

If you run clippy on master after running rustup update you get erros such as the following

error: this expression borrows a reference (`&arrow::ipc::writer::IpcWriteOptions`) that is immediately dereferenced by the compiler
   --> integration-testing/src/flight_client_scenarios/integration_test.rs:131:66
    |
131 |         arrow_flight::utils::flight_data_from_arrow_batch(batch, &options);
    |                                                                  ^^^^^^^^ help: change this to: `options`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression borrows a reference (`&[arrow::record_batch::RecordBatch]`) that is immediately dereferenced by the compiler
   --> integration-testing/src/flight_client_scenarios/integration_test.rs:169:17
    |
169 |                 &expected_data,
    |                 ^^^^^^^^^^^^^^ help: change this to: `expected_data`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

What changes are included in this PR?

  1. Fix clippy errors by doing its suggestions or suppressing

Are there any user-facing changes?

No

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Jul 29, 2021
@Dandandan Dandandan merged commit 2b2ec7e into apache:master Jul 29, 2021
alamb added a commit that referenced this pull request Jul 29, 2021
alamb added a commit that referenced this pull request Jul 29, 2021
@alamb alamb deleted the alamb/fixup_clippy branch October 26, 2021 13:11
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Aug 27, 2024
Can drop this after rebase on commit 2b2ec7e "Fix clippy lints for Rust 1.54 (apache#631)", first released in 6.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants