Fix compile error in cherry pick 2113e2b1 #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Merged
Codecov Report
@@ Coverage Diff @@
## cherry_pick_2113e2b1 #624 +/- ##
=======================================================
Coverage ? 82.48%
=======================================================
Files ? 167
Lines ? 46463
Branches ? 0
=======================================================
Hits ? 38327
Misses ? 8136
Partials ? 0 Continue to review full report at Codecov.
|
alamb
approved these changes
Jul 28, 2021
alamb
added a commit
that referenced
this pull request
Jul 29, 2021
* Sort binary (#569) * impl sort fixed binary array Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * remove array builder util, add test cases Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * impl sort for generic binary array Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * tidy Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * run clippy Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * test: fixed binary with different prefix Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * rebase master Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * Fix compile error in cherry pick 2113e2b (#624) Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
See discussion in here
What changes are included in this PR?
Fix compile error in cherry-pick #621.
Are there any user-facing changes?