-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of FixedLengthBinary
decoding
#6220
Conversation
While performance for decoding is still abominable, oddly this change improves it somewhat. On my laptop (old macbook pro w/ 2.2GHz core i7)
On my workstation (3.6 GHz Core i7-12700K)
|
FixedLengthBinary
decoding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @etseidl -- even if this didn't improve performance in my opinion it would still be a valuable change simply for readability.
Which issue does this PR close?
Tangentially related to #6219.
Rationale for this change
Following up on #6159 (comment), this adds
set_from_bytes
to the privateParquetValueType
trait. This avoids the need for downcasting for byte array types.What changes are included in this PR?
In addition to the above, it also changes the formatting in the encoding benchmark to distinguish between
FixedLenByteArray(2)
andFixedLenByteArray(16)
. Without this critcmp overwrites theFLBA(2)
results.Are there any user-facing changes?
No, changes are to private interfaces.